Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix artifacts path in appveyor.yml #1319

Merged
merged 1 commit into from
Oct 4, 2018

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries

Just noticed that after merging #1318, the coveralls.net .nupkg file is included in the build artifacts (https://ci.appveyor.com/project/stripe/stripe-dotnet/build/19.9.2.1608#L352), so I think Appveyor would try to push it to Nuget in the next tagged version. This PR prevents that (https://ci.appveyor.com/project/stripe/stripe-dotnet/build/19.9.2.1618#L364).

Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I would never have thought to look there. Another approach might be to configure where those artifacts are generated right?

@ob-stripe ob-stripe merged commit cfb1d57 into integration-next-major-version Oct 4, 2018
@ob-stripe ob-stripe deleted the ob-artifacts-nupkg branch October 4, 2018 15:27
@ob-stripe ob-stripe mentioned this pull request Oct 4, 2018
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants