Add missing attributes on StripeThreeDSecure #1279
Conversation
| public string Funding { get; set; } | ||
|
|
||
| [JsonProperty("google_reference")] | ||
| public string GoogleReference { get; set; } |
There was a problem hiding this comment.
I'm not sure what this is but it seems more internal than external I would not surface. I feel the same about IIN + Issuer + Description. It's gated and while it's supported on the Source resource I'm not convinced we should surface it here
There was a problem hiding this comment.
IIN, Issuer and Description are already available on StripeCard though.
There was a problem hiding this comment.
I removed GoogleReference.
There was a problem hiding this comment.
I know they are visible but I wanted to avoid leaking them further. Can you at least do what we do on the other resource: and group them with a comment, or add a comment to each one about being gated?
ob-stripe
force-pushed
the
ob-update-source-3ds
branch
from
8908d46 to
6ccf42a
Compare
ob-stripe
force-pushed
the
ob-update-source-3ds
branch
from
6ccf42a to
af673e3
Compare
|
I added XML comments for all attributes. ptal @remi-stripe |
| /// Whether the card was automatically updated at some point by Stripe or not. | ||
| /// </summary> | ||
| [JsonProperty("card_automatically_updated")] | ||
| public bool CardAutomaticallyUpdated { get; set; } |
There was a problem hiding this comment.
This is purely internal and should not be here (sorry only seeing it now)
There was a problem hiding this comment.
I'll remove it, but it is returned by the public API though (cf. the sample JSON in #1274)
There was a problem hiding this comment.
I know, but I also know it should not and that we flagged it and that it should have been fixed already.
ob-stripe
force-pushed
the
ob-update-source-3ds
branch
from
af673e3 to
2699225
Compare
|
ptal @remi-stripe |
|
Released in 19.6.0. |
r? @remi-stripe
cc @stripe/api-libraries @pradeepannepu
Adds all missing attributes on the
StripeThreeDSecuremodel class (including gated ones).Replaces #1274.