Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cancel support for topups #1245

Merged
merged 1 commit into from
Aug 3, 2018
Merged

Add cancel support for topups #1245

merged 1 commit into from
Aug 3, 2018

Conversation

ob-stripe
Copy link
Contributor

r? @brandur-stripe @remi-stripe
cc @stripe/api-libraries @foresthu-stripe

Add cancel support for topups.

I've also alphabetized methods in StripeTopupService.

Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment but likely not a blocker so approving

{
return Mapper<StripeTopup>.MapFromJson(
Requestor.PostString(
this.ApplyAllParameters(createOptions, Urls.Topups, false),
this.ApplyAllParameters(null, $"{Urls.Topups}/{topupId}/cancel", false),
this.SetupRequestOptions(requestOptions)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other services like the Payout one we did

return this.Post($"{Urls.BaseUrl}/payouts/{payoutId}/cancel", requestOptions);

which is bit more readable, Not sure what the difference is between StripeService and StripeBasicService though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack. I'll leave this one as-is for now. Let's add this to the list of things that should be standardized throughout the library.

@ob-stripe ob-stripe merged commit d7d265a into master Aug 3, 2018
@ob-stripe ob-stripe deleted the ob-topup-cancel branch August 3, 2018 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants