Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tolerance verification to check both past and future timestamps #1224

Merged
merged 1 commit into from
Jul 11, 2018
Merged

Improve tolerance verification to check both past and future timestamps #1224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Stripe.net/Services/Events/StripeEventUtility.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ public static StripeEvent ConstructEvent(string json, string stripeSignatureHead

var webhookUtc = Convert.ToInt32(signatureItems["t"].FirstOrDefault());

if (utcNow - webhookUtc > tolerance)
throw new StripeException("The webhook cannot be processed because the current timestamp is above the allowed tolerance.");
if (Math.Abs(utcNow - webhookUtc) > tolerance)
throw new StripeException("The webhook cannot be processed because the current timestamp is outside of the allowed tolerance.");

return Mapper<StripeEvent>.MapFromJson(json);
}
Expand Down