Add missing property/params to the InvoiceItem resource #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add unit_amount everywhere * Add quantity on create and update * Remove currency on update as it's not valid
remi-stripe
commented
Jul 6, 2018
| @@ -11,13 +11,16 @@ public class StripeInvoiceItemUpdateOptions : StripeBaseOptions, ISupportMetadat | |||
| [JsonProperty("description")] | |||
| public string Description { get; set; } | |||
|
|
|||
| [JsonProperty("currency")] | |||
There was a problem hiding this comment.
This is not valid per https://stripe.com/docs/api#update_invoiceitem which means it never worked so not sure if a breaking change
There was a problem hiding this comment.
If it never worked, then it's not a breaking change IMO.
ob-stripe
approved these changes
Jul 6, 2018
|
Released in 16.16.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @ob-stripe
cc @stripe/api-libraries