Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name to the Coupon resource #1211

Merged
merged 1 commit into from
Jun 20, 2018
Merged

Add name to the Coupon resource #1211

merged 1 commit into from
Jun 20, 2018

Conversation

remi-stripe
Copy link
Contributor

r? @ob-stripe
cc @stripe/api-libraries

@ob-stripe ob-stripe merged commit 9a61195 into master Jun 20, 2018
@ob-stripe ob-stripe deleted the remi-add-coupon-name branch June 20, 2018 16:37
@ob-stripe
Copy link
Contributor

Released in 16.11.0.

@winzig
Copy link
Contributor

winzig commented Jun 20, 2018

How does one update an existing coupon with the Name field?

Is this Name field intended to be shown in the receipts/invoices instead of the coupon ID code? If so, it doesn't appear to be working at this time. At least in my test dashboard, the Name only shows up when creating the invoice. When I get the actual invoice/receipt email, it still shows the "ID code" for the coupon instead.

Thanks!

@remi-stripe
Copy link
Contributor Author

@winzig This can not be updated today, it can only be set at creation. For the second part, it could be a bug but it's unrelated to the library. I would recommend contacting our support team to discuss this: https://support.stripe.com/email

@winzig
Copy link
Contributor

winzig commented Jun 20, 2018

@remi-stripe That's great news, I've filed a support request about the possible bug.

In terms of the update capability, is this planned soon? I'm a bit squeamish about trying to create a new coupon and replacing the existing coupons on our existing subscriptions. Being able to just update the name param on existing coupons would be highly desirable.

@remi-stripe
Copy link
Contributor Author

@winzig Not something we have planned for now but I will take this to the team and hopefully we can add this in the future

@winzig
Copy link
Contributor

winzig commented Jun 21, 2018

@remi-stripe Would it be helpful or unhelpful if I open an issue about this request?

@remi-stripe
Copy link
Contributor Author

@winzig Issues are specific to bugs with the libraries so I would recommend against it. Since you reporting it to our support team (and I did too with the eng team) for now the only thing to do is wait for us to implement it. I will add it to the libraries once support for it is added in the API!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants