Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for document_back #1201

Merged
merged 2 commits into from
Jun 12, 2018
Merged

Conversation

sedouard
Copy link
Contributor

With the introduction of the document_back parameter for both additional owners and the representative we can now update the back of photo IDs 🎉

This PR includes wrappers and tests for the associated wrappers.

@@ -13,10 +13,14 @@ public class StripeLegalEntityVerification : StripeEntity

#region Expandable Document
public string DocumentId { get; set; }
public string DocumentIdBack { get; set; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor but I think you should separate each region but will defer to ob

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had thought we might want to group it into the same region but tbh its been a while since I've worked with c#

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the purpose is purely an IDE feature. Would you as a developer want to collapse both of these together always or would there be a reason to have this in its own region? Since they're so related I would think we'd want them together but idk.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The convention so far has been to create a region for each expandable attribute, so I'd have a slight preference for sticking to the convention. That said, it's just an IDE feature so no strong feels here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I just placed it in its own region to follow convention. ✅

@remi-stripe
Copy link
Contributor

r? @ob-stripe
cc @stripe/api-libraries

@ob-stripe
Copy link
Contributor

Alright, pulling this in!

@ob-stripe ob-stripe merged commit a50e0d0 into stripe:master Jun 12, 2018
@ob-stripe
Copy link
Contributor

Released as 16.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants