Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Sigma scheduled queries #1174

Merged
merged 3 commits into from
May 7, 2018

Conversation

Mitch528
Copy link
Contributor

@Mitch528 Mitch528 commented May 6, 2018

No description provided.

@remi-stripe
Copy link
Contributor

@Mitch528 Thank you for doing the work here! As you can see, the tests are failing because the endpoint can only be used in Live mode.

Can you confirm that this works in Live mode for you? If so, you would have to comment the test out for now until we move the library to stripe-mock so that it does not break the build.

cc @stripe/api-libraries for awareness

@Mitch528
Copy link
Contributor Author

Mitch528 commented May 7, 2018

Yes, I can confirm that it works in live mode for me.

@remi-stripe
Copy link
Contributor

r? @brandur-stripe

@remi-stripe
Copy link
Contributor

@Mitch528 Can you comment the whole test file? Also only keep the XUnit one, we're likely going to remove the other test framework in the future so one file is enough :)

@brandur-stripe
Copy link
Contributor

LGTM as well.

Thanks a lot for the contribution here @Mitch528! Very much appreciated.

@brandur-stripe brandur-stripe merged commit f3f0b02 into stripe:master May 7, 2018
@brandur-stripe
Copy link
Contributor

We'll have to wait on CI to finish before the new release is pushed out to Nuget, but this will be coming out as 15.8.0.

@Mitch528 Mitch528 deleted the sigma-scheduled-queries branch December 1, 2018 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants