Add the ability to create a SEPA debit source from an Ideal one. #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-stripe
commented
Apr 13, 2018
| @@ -44,6 +44,9 @@ public class StripeSourceCreateOptions : StripeBaseOptions, ISupportMetadata | |||
| [JsonProperty("sepa_debit[iban]")] | |||
| public string SepaDebitIban { get; set; } | |||
|
|
|||
| [JsonProperty("sepa_debit[ideal]")] | |||
| public string SepaDebitIdealSource { get; set; } | |||
There was a problem hiding this comment.
I chose to add "Source" at the end as it takes a source id and in the future we might add an ideal hash so wanted to protect future us
ob-stripe
reviewed
Apr 13, 2018
| @@ -44,6 +44,9 @@ public class StripeSourceCreateOptions : StripeBaseOptions, ISupportMetadata | |||
| [JsonProperty("sepa_debit[iban]")] | |||
| public string SepaDebitIban { get; set; } | |||
|
|
|||
| [JsonProperty("sepa_debit[ideal]")] | |||
| public string SepaDebitIdealSource { get; set; } | |||
There was a problem hiding this comment.
I think this should be named SepaDebitIdealSourceId in order to be consistent with other parameters that expect an ID.
There was a problem hiding this comment.
fixed, sorry for the delay
remi-stripe
force-pushed
the
remi-add-sepa-ideal
branch
from
c04746b to
d3111f2
Compare
|
@ob-stripe PTAL |
Those tests do not work anymore as the Charge created on that token is not put in Review by Radar anymore. Comment those out so that we can look it up as needed in the future.
remi-stripe
force-pushed
the
remi-add-sepa-ideal
branch
from
b2903f7 to
ee9c2be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1153
r? @ob-stripe
cc @stripe/api-libraries