Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more Expand and change Outcome to be auto expanded #1139

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

remi-stripe
Copy link
Contributor

@remi-stripe remi-stripe commented Mar 17, 2018

Expand support has been improved:

  • Account: BusinessLogo
  • ApplicationFee: OriginatingTransaction
  • ApplicationFeeRefund: BalanceTransaction, Fee
  • Charge: Order
  • Invoice: Subscription
  • InvoiceItem: Subscription
  • Order: Charge, Customer
  • Refund: FailureBalanceTransaction
  • SKU: Product
  • Transfer: Destination, DestinationPayment, SourceTransaction

Modified Outcome on the Charge resource to be automatically expanded and renamed Rule to RuleId as this is not expanded by default as of API version 2017-02-14.

This fixes #741

r? @ob-stripe
cc @stripe/api-libraries

Expand support has been increased:
* Account: BusinessLogo
* ApplicationFee: OriginatingTransaction
* ApplicationFeeRefund: BalanceTransaction, Fee
* Charge: Order
* Invoice: Subscription
* InvoiceItem: Subscription
* Order: Charge, Customer
* Refund: FailureBalanceTransaction
* SKU: Product
* Transfer: Destination, DestinationPayment, SourceTransaction

Modified Outcome on the Charge resource to be automatically expanded and
renamed Rule to RuleId as this is not expanded by default as of API
version 2017-02-14.
@remi-stripe remi-stripe force-pushed the remi-add-more-expand branch from 5146ab7 to 93a92e8 Compare March 17, 2018 20:21
Copy link
Contributor

@ob-stripe ob-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ob-stripe ob-stripe merged commit 269f67d into master Mar 21, 2018
@ob-stripe ob-stripe deleted the remi-add-more-expand branch March 21, 2018 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StripeInvoiceService ExpandSubscription
2 participants