Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for redirect_url when creating login_links #1138

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Conversation

ob-stripe
Copy link
Contributor

r? @remi-stripe
cc @stripe/api-libraries @Ramoji

Add support for redirect_url when creating login_links.

Unfortunately a breaking change because previously StripeLoginLinkService.Create() did not accept request options so I had to change the signature.

Fixes #1137.

Copy link
Contributor

@remi-stripe remi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I had no idea we added this parameter months ago!

@ob-stripe ob-stripe merged commit 15372e4 into master Mar 16, 2018
@ob-stripe ob-stripe deleted the ob-fix-1137 branch March 16, 2018 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants