Minor webhook signing improvements #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fred-stripe Great changes -- +1 to removing the special |
|
Released in 13.0.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two improvements here:
ConstructEventnow throws aStripeExceptioninstead of a genericException, which prevents calling code from catching non-SDK related errors when constructing events.EpochUtcNowOverrideclass member, which was only used by the test suite.I had to add a couple more constructors to
StripeException, as the existing constructor was only for errors during HTTP requests. As a bigger project I'd like to see us leaveStripeExceptionas a generic exception and derive anStripeHTTPExceptionclass fromStripeException, which would cleanly break up the class responsibilities. It'd also allow us to add custom exception formatting and better surface non-200 HTTP responses and API error messages.r? @ob-stripe
cc @stripe/api-libraries @rpaul-stripe