Make "exchange rate" singular #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur-stripe
force-pushed
the
brandur-singular-exchange-rate
branch
from
32adefb to
f805ba5
Compare
We've recently tweaked the very new exchange rates API somewhat so that a single "exchange rate" resource becomes singular instead of plural. This is so that it falls into convention with all the other resources in the API. I jumped the gun a little bit of merging the .NET pull request, so this one goes back through and amends a few places that were using a plural exchange rate so that they're now singular. Apparently we got a little lucky because 11.7.0 (the version I sent this out under) apparently never made it to Nuget (possibly a build failure which I'll have to look into separately). But anyway, it's safe to release this without a breaking change because there is no official package release with the other API.
brandur-stripe
force-pushed
the
brandur-singular-exchange-rate
branch
from
f805ba5 to
4fdc5ce
Compare
|
lgtm! Thanks for handling. |
|
Thanks Olivier. Released as 11.7.1. I'm pretty sure I found the problem that was causing the build failure, so with any luck this version will make it over to Nuget. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've recently tweaked the very new exchange rates API somewhat so that
a single "exchange rate" resource becomes singular instead of plural.
This is so that it falls into convention with all the other resources in
the API.
I jumped the gun a little bit of merging the .NET pull request, so this
one goes back through and amends a few places that were using a plural
exchange rate so that they're now singular.
Apparently we got a little lucky because 11.7.0 (the version I sent this
out under) apparently never made it to Nuget (possibly a build failure
which I'll have to look into separately). But anyway, it's safe to
release this without a breaking change because there is no official
package release with the other API.
r? @ob-stripe
cc @stripe/api-libraries