Improve parameter encoding #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob-stripe
commented
Oct 24, 2017
| if (!type.GetTypeInfo().IsGenericType) return false; | ||
| if (type.GetTypeInfo().GetGenericTypeDefinition() != typeof(Dictionary<,>)) return false; | ||
|
|
||
| // Ensure that key and value types are both string |
There was a problem hiding this comment.
There's probably a way to be able to encode any Dictionary<object, object> by calling ToString() on keys and values, but I couldn't manage with my meager .NET reflection skills, so I'm just throwing an exception if the key and/or value type is not string.
It's not a big deal as all dictionaries in the library are <string, string> right now and the explicit exception should prevent contributors from mistakenly using other types.
There was a problem hiding this comment.
Honestly, I think some explicitness is better here than more reflection magic :)
+1 on the ArgumentExceptions.
|
Great work as usual OB :) That cleanup around arrays is top notch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brandur-stripe
cc @stripe/api-libraries
Fixes #1042.
This PR adds general improvements to parameter encoding:
dictionary keys are now properly URL-encoded
all dictionaries are now automatically correctly encoded (got rid of the special-casing based on parameter names in
DictionaryPlugin)all arrays are now automatically correctly encoded (got rid of the special-casing based on prefixing the parameter names with
array:)added some tests