Updating image template to include arch #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcheung-stripe
approved these changes
Nov 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
r? @vcheung-stripe
cc @stripe/developer-products
Summary
Users reported not being able to run the stripe binary that comes in the docker image: #993.
For some reason, I wasn't able to reproduce this with either version on my WSL2 setup, but I could verify that the 12.4.1 version would always pull the x86_64 and the 1.13.0 would always pull ARM. I think we just end up with whatever version we last pushed to the image since they share the same template.
This adds the arch to the image template so we can have both instances. I would hope that grabbing just
stripe/stripe-cliwould grab the latest and correct arch automatically, but I'll have to test this after we run the release.