-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FC] Sends supports_app_verification to sync call when Integrity available #9819
Merged
carlosmuvi-stripe
merged 1 commit into
master
from
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
Jan 13, 2025
Merged
[FC] Sends supports_app_verification to sync call when Integrity available #9819
carlosmuvi-stripe
merged 1 commit into
master
from
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
Jan 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
carlosmuvi-stripe
changed the title
Sends supports_app_verification to syncrhonize when Integrity available
Add app verification support to Financial Connections
Dec 21, 2024
carlosmuvi-stripe
changed the title
Add app verification support to Financial Connections
Adds
Dec 21, 2024
carlosmuvi-stripe
changed the title
Adds
Sends supports_app_verification to sync call when Integrity available
Dec 21, 2024
Diffuse output:
APK
|
3 tasks
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
2 times, most recently
from
December 23, 2024 10:41
5da26c9
to
ecc939b
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-prepares_integrity_on_first_sync_call
branch
from
December 23, 2024 10:47
dae2c69
to
706894d
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
December 23, 2024 10:47
ecc939b
to
30a830a
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-prepares_integrity_on_first_sync_call
branch
from
December 23, 2024 11:52
706894d
to
04b27ef
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
December 23, 2024 11:52
30a830a
to
b87210e
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-prepares_integrity_on_first_sync_call
branch
from
December 23, 2024 12:03
04b27ef
to
69c825d
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
December 23, 2024 12:04
b87210e
to
b2bb731
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-prepares_integrity_on_first_sync_call
branch
from
December 23, 2024 12:12
69c825d
to
1f9ede2
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
December 23, 2024 12:12
b2bb731
to
c053783
Compare
3 tasks
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-prepares_integrity_on_first_sync_call
branch
from
December 23, 2024 12:17
1f9ede2
to
f49fde3
Compare
carlosmuvi-stripe
changed the title
Sends supports_app_verification to sync call when Integrity available
[FC] Sends supports_app_verification to sync call when Integrity available
Dec 23, 2024
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
December 23, 2024 12:17
c053783
to
03c604c
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-prepares_integrity_on_first_sync_call
branch
from
December 23, 2024 14:26
a153a66
to
1840272
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
December 23, 2024 14:27
03c604c
to
eed6066
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-prepares_integrity_on_first_sync_call
branch
from
December 23, 2024 14:28
1840272
to
ef32d6f
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
December 23, 2024 14:28
eed6066
to
ade027d
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-prepares_integrity_on_first_sync_call
branch
from
December 24, 2024 13:08
ef32d6f
to
8b718ff
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
2 times, most recently
from
December 24, 2024 15:26
60ad1f8
to
6ff391a
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-prepares_integrity_on_first_sync_call
branch
from
December 25, 2024 11:00
9be7b86
to
67af8e1
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
December 25, 2024 11:00
6ff391a
to
92d3005
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
January 2, 2025 18:09
75b1536
to
7cf4405
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-prepares_integrity_on_first_sync_call
branch
from
January 9, 2025 00:23
eaa23cd
to
b376dfb
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
January 9, 2025 00:24
7cf4405
to
acc3862
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-prepares_integrity_on_first_sync_call
branch
from
January 9, 2025 04:59
b376dfb
to
196fb04
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
January 9, 2025 04:59
acc3862
to
0112b88
Compare
tillh-stripe
previously approved these changes
Jan 10, 2025
@@ -125,7 +128,7 @@ internal class FinancialConnectionsSheetViewModel @Inject constructor( | |||
} | |||
|
|||
private suspend fun prepareStandardRequestManager(): Boolean { | |||
val result = runCatching { integrityRequestManager.prepare() } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@@ -18,12 +18,14 @@ internal class GetOrFetchSync @Inject constructor( | |||
) { | |||
|
|||
suspend operator fun invoke( | |||
refetchCondition: RefetchCondition = RefetchCondition.None | |||
refetchCondition: RefetchCondition = RefetchCondition.None, | |||
attestationInitialized: Boolean? = null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a fan of nullable booleans. Can we just pass false
?
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-prepares_integrity_on_first_sync_call
branch
from
January 10, 2025 17:12
196fb04
to
0692e55
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
January 10, 2025 17:12
0112b88
to
31c0f8f
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-prepares_integrity_on_first_sync_call
branch
2 times, most recently
from
January 10, 2025 17:34
e3b89e3
to
7ed2677
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
January 10, 2025 17:35
31c0f8f
to
19bb247
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-prepares_integrity_on_first_sync_call
branch
from
January 10, 2025 18:24
7ed2677
to
4bfb6b4
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
January 10, 2025 18:24
19bb247
to
383d472
Compare
carlosmuvi-stripe
changed the base branch from
carlosmuvi/12-21-prepares_integrity_on_first_sync_call
to
graphite-base/9819
January 10, 2025 20:38
carlosmuvi-stripe
force-pushed
the
graphite-base/9819
branch
from
January 10, 2025 20:39
4bfb6b4
to
1a9b1e7
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
January 10, 2025 20:39
383d472
to
a112049
Compare
carlosmuvi-stripe
dismissed
tillh-stripe’s stale review
January 10, 2025 20:39
The base branch was changed.
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
January 10, 2025 20:39
a112049
to
9332cd6
Compare
carlosmuvi-stripe
force-pushed
the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
from
January 10, 2025 21:05
9332cd6
to
ad9e8a8
Compare
tillh-stripe
approved these changes
Jan 13, 2025
Merge activity
|
carlosmuvi-stripe
deleted the
carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available
branch
January 13, 2025 14:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When making the first
/sync
request, warm up the integrity request calling managerprepare
to check if Integrity API is available. If no errors occur, Passsupports_app_verification: true
on the first sync call.Note: This gets recorded on the session so even if future sync calls pass this field it'd get ignored, as the session verified state is immutable on backend.
We also pass
verified_app_id
, matching the package name.Motivation
https://docs.google.com/document/d/1joKz5UZHLVazmecfMHbq6gB6n4wj5u8To6AtqYgq_tc/edit?tab=t.0#heading=h.cz1xkpga7giy
Testing