Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ErrorMessageTranslator and default implementation #807

Merged
merged 1 commit into from
Feb 13, 2019

Conversation

mshafrir-stripe
Copy link
Collaborator

@mshafrir-stripe mshafrir-stripe commented Feb 12, 2019

Summary

ErrorMessageTranslator is an interface that a user can
implement to specify custom translations for
server-provided errors.

Motivation

Stripe error messages are in English. In a few places,
we show these messages on screen in dialogs. An app
developer may wish to provide their own translation of
these messages so that are legibile to their customers.

Fixes #680

Testing

Added unit tests.

**Summary**
ErrorMessageTranslator is an interface that a user can
implement to specify custom translations for
server-provided errors.

**Motivation**
Stripe error messages are in English. In a few places,
we show these messages on screen in dialogs. An app
developer may wish to provide their own translation of
these messages so that are legibile to their customers.

Fixes #680
@mshafrir-stripe mshafrir-stripe merged commit ea40ee8 into master Feb 13, 2019
@mshafrir-stripe mshafrir-stripe deleted the error-message-translator branch February 13, 2019 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants