-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update compose pay button to version 0.1.4 #8006
Conversation
@samer-stripe this is approved, but no checks are running... Could you please have a second look here? 🤔 |
Hmm.. Seems the annotation is not available anymore 🤔. Maybe even a wrong one was used 🤷♂️ Might have a look later... |
@samer-stripe i fixed the annotation. Now it should work 🙃 |
@samer-stripe whats the problem with the tests? 🤔 |
@samer-stripe ping 🤓 |
4f32fd1
to
f5c4c05
Compare
@StefMa Bitrise and the other GitHub actions won't run on a branch from the remotely forked repo. Could you open a PR from a local fork of this repo? |
Sorry @samer-stripe but I understand what you mean. What is a local fork? 🤔 I already opened a PR a few month ago. Even if that also included failing tests, it seems that @jaynewstrom-stripe somehow got the tests running on at least bitrise... 🤔 |
@samer-stripe can we just merge it? 🙈 |
Hey guys, |
I brought your change in and rebased it here: https://github.com/stripe/stripe-android/pull/8172/files and I also applied our dependency update script, which gives us a detailed view of what changed. As is, this (transitively) updates compose to 1.6, which we're not quite ready to force all of our downstream consumers onto. As a workaround, you can depend directly on compose pay button 1.0.0 in your application, which will transitively updated stripes dependency as well, unblocking you from updating in your application. Thanks for the contribution, once we're ready to update to compose 1.6 and compose pay button 1.0.0, we will take this contribution so you will get attributed. |
Thanks for looking into it 🚀 |
Summary
Just a small update of the compose pay button dependency.
Motivation
Background is that we are using stripe (so this library 😁 ) together with licensee.
Unfortunately up to version 0.1.3 compose pay button didn't provide a valid
<license>
tag in their POM.This prevents us to update stripe as the transitive dependency compose pay button will report as "invalid license" (for us).
This is now fixed, since compose pay button has the default Apache 2 license 🙂
See also the following related issue and PR:
google-pay/compose-pay-button#17
google-pay/compose-pay-button#18
Seems this is the full changelog/diff of the update:
https://github.com/google-pay/compose-pay-button/compare/fc3aacfd0bb632bdda40ba915f616a4a0cd0f87f..3418fd1ffd9dc9d9c88e368e721649f8ad0c62df
Testing
Screenshots
Changelog