Add StripeError field to StripeException #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** Add a `StripeError` field to `StripeException`. Access via `StripeException#getStripeError()` **Motivation** The error code is an important field for SDK users to be able to determine why a request failed, and allows them to better react to the failure. For example, a `"payment_method_not_available"` code may suggest to the developer to invite a customer to use another payment method. Additionally, a developer may choose to localize an user-facing error based on this code. Fixes #792 **Testing** Wrote automated tests.
mshafrir-stripe
force-pushed
the
stripe-error
branch
from
b8c86c4 to
539415e
Compare
csabol-stripe
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a
StripeErrorfield toStripeException.Access via
StripeException#getStripeError()Motivation
The error code is an important field for SDK users
to be able to determine why a request failed, and
allows them to better react to the failure.
For example, a
"payment_method_not_available"codemay suggest to the developer to invite a customer to
use another payment method. Additionally, a developer
may choose to localize an user-facing error based on
this code.
Fixes #792
Testing
Wrote automated tests.