Fix IME action logic on CVC field in CardMultilineWidget #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** If the postal code field is not shown, the CVC field is the last one in the form and the action on the keyboard when the CVC field is focused should be "Done" (i.e. checkmark). Otherwise, show the "Next" action (i.e. right arrow). **Motivation** Showing the correct IME action improves user experience and accessibility https://developer.android.com/training/keyboard-input/style#Action
|
Looks good. It would also be interesting to know why I don't see "done" button in the action bar. Anyway having keyboard's button behaving correctly is a big deal. Thanks for fixing. |
csabol-stripe
approved these changes
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the postal code field is not shown, the CVC field
is the last one in the form and the action on the
keyboard when the CVC field is focused should be
"Done" (i.e. checkmark - see screenshot).
Otherwise, show the "Next" action (i.e. right arrow).
Motivation
Showing the correct IME action improves user experience
and accessibility
https://developer.android.com/training/keyboard-input/style#Action