Enable CBC on all surfaces #7713

tillh-stripe · 2023-12-11T20:59:27Z

Summary

This pull request enables card brand choice in all our surfaces and removes the associated feature flag.

Motivation

Testing

Added tests
Modified tests
Manually verified

Screenshots

Before	After
before screenshot	after screenshot

Changelog

github-actions · 2023-12-11T21:09:27Z

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │           uncompressed           
          ├───────────┬───────────┬────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff     
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
      dex │   3.6 MiB │   3.6 MiB │ +812 B │   7.8 MiB │   7.8 MiB │ +1.4 KiB 
     arsc │   2.3 MiB │   2.3 MiB │    0 B │   2.3 MiB │   2.3 MiB │      0 B 
 manifest │   5.1 KiB │   5.1 KiB │    0 B │  25.4 KiB │  25.4 KiB │      0 B 
      res │ 922.9 KiB │ 922.9 KiB │    0 B │   1.4 MiB │   1.4 MiB │      0 B 
   native │   2.6 MiB │   2.6 MiB │    0 B │     6 MiB │     6 MiB │      0 B 
    asset │     3 MiB │     3 MiB │  -16 B │     3 MiB │     3 MiB │    -16 B 
    other │ 205.3 KiB │ 205.3 KiB │   +7 B │ 462.1 KiB │ 462.1 KiB │      0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼──────────
    total │  12.5 MiB │  12.5 MiB │ +803 B │  20.9 MiB │  20.9 MiB │ +1.3 KiB 

 DEX     │ old   │ new   │ diff            
─────────┼───────┼───────┼─────────────────
   files │     1 │     1 │   0             
 strings │ 38790 │ 38794 │  +4 (+13 -9)    
   types │ 12983 │ 12986 │  +3 (+11 -8)    
 classes │ 10970 │ 10973 │  +3 (+3 -0)     
 methods │ 53926 │ 53934 │  +8 (+366 -358) 
  fields │ 35881 │ 35892 │ +11 (+338 -327) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  292 │  292 │  0   
 entries │ 6939 │ 6939 │  0

APK

    compressed     │     uncompressed     │                                
──────────┬────────┼───────────┬──────────┤                                
 size     │ diff   │ size      │ diff     │ path                           
──────────┼────────┼───────────┼──────────┼────────────────────────────────
  3.6 MiB │ +812 B │   7.8 MiB │ +1.4 KiB │ ∆ classes.dex                  
  6.7 KiB │  -18 B │   6.6 KiB │    -18 B │ ∆ assets/dexopt/baseline.prof  
   66 KiB │   +5 B │   148 KiB │      0 B │ ∆ META-INF/CERT.SF             
 50.2 KiB │   +5 B │ 147.9 KiB │      0 B │ ∆ META-INF/MANIFEST.MF         
  1.2 KiB │   -3 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA            
    851 B │   +2 B │     719 B │     +2 B │ ∆ assets/dexopt/baseline.profm 
──────────┼────────┼───────────┼──────────┼────────────────────────────────
  3.7 MiB │ +803 B │   8.1 MiB │ +1.3 KiB │ (total)

DEX

STRINGS:

   old   │ new   │ diff        
  ───────┼───────┼─────────────
   38790 │ 38794 │ +4 (+13 -9) 
  + Lbd/h0;
  + Ldd/u0;
  + Lvg/m4;
  + [Lvg/c2;
  + [Lvg/k4;
  + [Lvg/l3;
  + [Lvg/r1;
  + [Lvg/r2;
  + [Lvg/w3;
  + [Lvg/y1;
  + [Lvg/y3;
  + https://merchant-ui-api.stripe.com/elements/mobile-card-element-config
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:24ad402,r8-mode:full,version:8.2.33}
  
  - [Lvg/b2;
  - [Lvg/j3;
  - [Lvg/j4;
  - [Lvg/p2;
  - [Lvg/q1;
  - [Lvg/v3;
  - [Lvg/x1;
  - [Lvg/x3;
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:e4793df,r8-mode:full,version:8.2.33}
  

TYPES:

   old   │ new   │ diff        
  ───────┼───────┼─────────────
   12983 │ 12986 │ +3 (+11 -8) 
  + Lbd/h0;
  + Ldd/u0;
  + Lvg/m4;
  + [Lvg/c2;
  + [Lvg/k4;
  + [Lvg/l3;
  + [Lvg/r1;
  + [Lvg/r2;
  + [Lvg/w3;
  + [Lvg/y1;
  + [Lvg/y3;
  
  - [Lvg/b2;
  - [Lvg/j3;
  - [Lvg/j4;
  - [Lvg/p2;
  - [Lvg/q1;
  - [Lvg/v3;
  - [Lvg/x1;
  - [Lvg/x3;
  

METHODS:

   old   │ new   │ diff           
  ───────┼───────┼────────────────
   53926 │ 53934 │ +8 (+366 -358) 
  + ad.d3 <init>(String, Integer, Integer, String, String, Set, c3, int)
  + androidx.recyclerview.widget.j0 <init>(b3)
  + bd.a0 <clinit>()
  + bd.b0 a(JSONObject) → z2
  + bd.d0 a(JSONObject) → b4
  + bd.e0 <clinit>()
  + bd.e0 a(JSONObject) → j4
  + bd.f0 a(JSONObject) → k4
  + bd.g0 <init>()
  + bd.g0 a(JSONObject) → m4
  + bd.h0 u(JSONObject) → h
  + bd.x u(JSONObject) → h
  + bd.y <clinit>()
  + bd.z <init>()
  + bd.z a(JSONObject) → a2
  + bd.z u(JSONObject) → h
  + cf.e <init>(t0, o, f, z)
  + com.stripe.android.view.CardBrandView a() → c3
  + com.stripe.android.view.CardMultilineWidget getCardNumberErrorListener_payments_core_release() → i4
  + com.stripe.android.view.CardMultilineWidget getCvcErrorListener_payments_core_release() → i4
  + com.stripe.android.view.CardMultilineWidget getExpirationDateErrorListener_payments_core_release() → i4
  + com.stripe.android.view.CardMultilineWidget getPostalCodeErrorListener_payments_core_release() → i4
  + com.stripe.android.view.CardMultilineWidget setCardNumberErrorListener(i4)
  + com.stripe.android.view.CardMultilineWidget setCardNumberErrorListener_payments_core_release(i4)
  + com.stripe.android.view.CardMultilineWidget setCvcErrorListener(i4)
  + com.stripe.android.view.CardMultilineWidget setCvcErrorListener_payments_core_release(i4)
  + com.stripe.android.view.CardMultilineWidget setExpirationDateErrorListener(i4)
  + com.stripe.android.view.CardMultilineWidget setExpirationDateErrorListener_payments_core_release(i4)
  + com.stripe.android.view.CardMultilineWidget setPostalCodeErrorListener(i4)
  + com.stripe.android.view.CardMultilineWidget setPostalCodeErrorListener_payments_core_release(i4)
  + com.stripe.android.view.PaymentAuthWebViewActivity m() → j2
  + com.stripe.android.view.PaymentFlowActivity n() → w2
  + com.stripe.android.view.PaymentFlowActivity p() → a3
  + com.stripe.android.view.PaymentMethodsActivity k() → r3
  + com.stripe.android.view.PaymentMethodsActivity l() → k3
  + com.stripe.android.view.PaymentMethodsActivity n() → v3
  + com.stripe.android.view.PostalCodeEditText getConfig_payments_core_release() → w3
  + com.stripe.android.view.PostalCodeEditText setConfig_payments_core_release(w3)
  + com.stripe.android.view.ShippingInfoWidget a(y3) → boolean
  + com.stripe.android.view.StripeEditText setAfterTextChangedListener(g4)
  + com.stripe.android.view.StripeEditText setDeleteEmptyListener(h4)
  + com.stripe.android.view.StripeEditText setErrorMessageListener(i4)
  + dd.a0 <init>(t0, e)
  + dd.b0 <init>(t0, e)
  + dd.c0 <init>(t0, e)
  + dd.d0 <init>(t0, e)
  + dd.e0 <init>(t0, e)
  + dd.f0 <init>(t0, e)
  + dd.f <init>(t0, e)
  + dd.g0 <init>(t0, e)
  + dd.h0 <init>(t0, e)
  + dd.i0 <init>(t0, e)
  + dd.j0 <init>(t0, e)
  + dd.j <init>(t0, e)
  + dd.k0 <init>(t0, e)
  + dd.l0 <init>(t0, e)
  + dd.l <init>(t0, e)
  + dd.m0 <init>(t0, e)
  + dd.m <init>(t0, e)
  + dd.n0 <init>(t0, e)
  + dd.n <init>(t0, Set, int)
  + dd.o0 <init>(t0, e)
  + dd.o <init>(t0, e)
  + dd.p0 <init>(t0, e)
  + dd.p <init>(t0, int)
  + dd.q0 <init>(t0, e)
  + dd.q <init>(t0, e)
  + dd.r0 <init>(t0, e)
  + dd.r <init>(t0, e)
  + dd.s0 <init>(t0, e)
  + dd.s0 i(Object) → Object
  + dd.s <init>(t0, e)
  + dd.t0 <clinit>()
  + dd.t0 <init>(Context, a, j, Set, e, c, e)
  + dd.t0 <init>(Context
...✂

tillh-stripe added 3 commits December 11, 2023 22:00

Remove CBC feature flag

b1613aa

Add release note

d0c0de3

Make methods public and add docs

94de769

tillh-stripe force-pushed the tillh/enable-cbc branch from 6484f32 to b21fdce Compare December 11, 2023 21:01

Update API

c35c810

tillh-stripe force-pushed the tillh/enable-cbc branch from b21fdce to c35c810 Compare December 11, 2023 21:01

tillh-stripe marked this pull request as ready for review December 11, 2023 21:03

tillh-stripe requested review from a team as code owners December 11, 2023 21:03

tillh-stripe requested review from awush-stripe, jaynewstrom-stripe and samer-stripe and removed request for awush-stripe December 11, 2023 21:03

Fix lint and remove outdated test

191854e

samer-stripe previously approved these changes Dec 12, 2023

View reviewed changes

Add link to changelog

2e8884d

tillh-stripe dismissed samer-stripe’s stale review via 2e8884d December 14, 2023 16:28

tillh-stripe requested a review from samer-stripe December 14, 2023 16:28

tillh-stripe enabled auto-merge (squash) December 14, 2023 16:28

samer-stripe approved these changes Dec 14, 2023

View reviewed changes

tillh-stripe merged commit 9b110a8 into master Dec 14, 2023
11 checks passed

tillh-stripe deleted the tillh/enable-cbc branch December 14, 2023 16:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable CBC on all surfaces #7713

Enable CBC on all surfaces #7713

tillh-stripe commented Dec 11, 2023 •

edited

Loading

github-actions bot commented Dec 11, 2023 •

edited

Loading

Enable CBC on all surfaces #7713

Enable CBC on all surfaces #7713

Conversation

tillh-stripe commented Dec 11, 2023 • edited Loading

Summary

Motivation

Testing

Screenshots

Changelog

github-actions bot commented Dec 11, 2023 • edited Loading

tillh-stripe commented Dec 11, 2023 •

edited

Loading

github-actions bot commented Dec 11, 2023 •

edited

Loading