Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn on missing financialconnections classes. #7570

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

jaynewstrom-stripe
Copy link
Collaborator

Summary

Fix an issue where financial connections classes would throw a warning when compiling with R8.

Motivation

Fixes #7569

Testing

  • Added tests
  • Modified tests
  • Manually verified

Copy link
Contributor

github-actions bot commented Nov 2, 2023

Risky Change

This is considered a risky change because it adjusts the sample app build.gradle, please review carefully.
We've seen issues in the past which resulted in failed builds for merchants. Please make sure the build.gradle change is intended.

By adding the label accept-risky-change to this PR, I acknowledge that I'm changing an example app and have verified that the SDK remains in a shippable state.

Copy link

emerge-tools bot commented Nov 2, 2023

1 build had no size change

Name Version Download Change Install Change
PaymentSheet Example 20.34.3 (11) 8.1 MB - 15.1 MB -

PaymentSheet Example 20.34.3 (11)

No changes to report


🛸 Powered by Emerge Tools

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Till Hellmund <[email protected]>
@jaynewstrom-stripe jaynewstrom-stripe enabled auto-merge (squash) November 2, 2023 14:38
@jaynewstrom-stripe jaynewstrom-stripe merged commit b57e7b9 into master Nov 2, 2023
7 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/dontwarn-fc branch November 2, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] R8 fails because of missing classes after upgrade to 20.34.3
2 participants