Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Navigating back from institution picker requires two taps #7331

Conversation

carlosmuvi-stripe
Copy link
Collaborator

@carlosmuvi-stripe carlosmuvi-stripe commented Sep 19, 2023

Summary

  • Problem: PartnerAuth navigates to InstitutionPicker without isSingleTop. That creates a second instance of the picker (that already exists on the back stack)
  • Solution: Make it singleTop. This PR makes singleTop the default on the flow, as we never want two instances of the same screen.

Motivation

📔  [Android] Navigating back from institution picker requires two taps
🌐  BANKCON-7646

It seems like the bug is because of a missing isSingleTop = true in cancelAuthSessionAndContinue

Testing

you can test running Maestro tests: maestro test -e APP_ID=com.stripe.android.financialconnections.example maestro/financial-connections/

  • Added tests
  • Modified tests
  • Manually verified

@carlosmuvi-stripe carlosmuvi-stripe added the work-cli Added to pull requests created with #work-cli for usage tracking. label Sep 19, 2023
@carlosmuvi-stripe carlosmuvi-stripe self-assigned this Sep 19, 2023
@carlosmuvi-stripe carlosmuvi-stripe marked this pull request as ready for review September 19, 2023 18:50
@carlosmuvi-stripe carlosmuvi-stripe requested review from a team as code owners September 19, 2023 18:50
CHANGELOG.md Outdated Show resolved Hide resolved
tillh-stripe
tillh-stripe previously approved these changes Sep 19, 2023
@carlosmuvi-stripe carlosmuvi-stripe merged commit 7e38e81 into master Sep 19, 2023
@carlosmuvi-stripe carlosmuvi-stripe deleted the carlosmuvi/BANKCON-7646/android-navigating-back-from-institution-picker-re branch September 19, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work-cli Added to pull requests created with #work-cli for usage tracking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants