-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alma as a new payment method to Android PaymentSheet #7302
Conversation
944be27
to
7e1cde3
Compare
Diffuse output:
APK
DEX
ARSC
|
CHANGELOG.md
Outdated
@@ -22,6 +22,7 @@ | |||
* [7269](https://github.com/stripe/stripe-android/pull/7269) iDEAL | |||
* [7270](https://github.com/stripe/stripe-android/pull/7270) SEPA | |||
* [7272](https://github.com/stripe/stripe-android/pull/7272) Sofort | |||
* [7302](https://github.com/stripe/stripe-android/pull/7302) Alma |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this landed in the wrong release. Want to move it up to the most recent?
paymentsheet-example/src/androidTest/java/com/stripe/android/lpm/TestAlma.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
31a8bea
to
f8b0320
Compare
CHANGELOG.md
Outdated
* [ADDED][7281](https://github.com/stripe/stripe-android/pull/7281) PaymentSheet now supports OXXO for PaymentIntents. | ||
* [ADDED] PaymentSheet now supports the following payment methods for PaymentIntents: | ||
* [7281](https://github.com/stripe/stripe-android/pull/7281) OXXO | ||
* [7302](https://github.com/stripe/stripe-android/pull/7302) Alma |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is in a previous release again (sorry for the hotfix).
Can you bump this up and make it look something like
### PaymentSheet
* [ADDED][7302](https://github.com/stripe/stripe-android/pull/7302) PaymentSheet now supports Alma for PaymentIntents.
But now that I'm thinking about this, I'm not sure we want to do this if merchants need to be gated. Do we have a link where they can request an invitation to the beta?
f8b0320
to
5d93dfe
Compare
Summary
Added Alma as a new payment method to Android PaymentSheet
Motivation
https://jira.corp.stripe.com/browse/THREEP_API-1035
Testing
Screenshots
Changelog