Fix bottom sheet for APIs below 30 #7239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillh-stripe
force-pushed
the
tillh/bottom-sheet-api-29-fix
branch
from
9b44f7f to
bc28c35
Compare
tillh-stripe
requested review from
ccen-stripe,
jameswoo-stripe,
jaynewstrom-stripe and
samer-stripe
and removed request for
ccen-stripe
jaynewstrom-stripe
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes an issue on APIs below 30 where
WindowInsets.isImeVisibleseemingly always returns true, which resulted in our bottom sheet dismissal being broken.Motivation
Testing
Screenshots
Changelog