-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use two decimal places for LAK #7190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Let's add a test an ship it!
Yep, was planning on adding it (and just did)! |
I think this is worth mentioning in the changelog! |
@porter-stripe Yes, added it to the changelog already. I’m just looking into aligning Google Pay with this change, because we continue to display the incorrect amount there. |
Diffuse output:
APK
DEX
|
Summary
This pull request fixes an issue where the Laotian Kip was formatted incorrectly.
To fix this, I added
LAK
to the special cases inCurrencyFormatter
and also madePayWithGoogleUtils
use that class to determine the amount of decimal places. This makes sure that PaymentSheet and Google Pay display the same values.Motivation
RUN_MOBILESDK-2548
Testing
Screenshots
Changelog