Open redirect activity with singleTask launchMode #7153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We started observing deep links not working on DuckDuckGo on Financial Connections:
FinancialConnectionsNativeActivity
) opens a browser to handle bank logins.RedirectActivity
) it opens it on that new task.RedirectActivity
relies onsingleTop
to restore the existingFinancialConnectionsNativeActivity
and continue the flow. However, since the activity is in a new task, we're not able to reopen it, so it creates a new instance of it (instead of bringing the existing one to front and callingonNewIntent
)Result -> the user stays in DuckDuckGo. (looks like deeplink didn't' trigger)
Solution
Solution: Open the activity observing deep links (
RedirectActivity
) with singleTask launch mode.This should ensure that the activity opens in an existing task with the same affinity (same app by default)
Testing
Tested this printing the
TaskId
ofFinancialConnectionsNativeActivity
andRedirectActivity
. They have different ids before singleTask, but they share the same id now.onNewIntent
gets triggered as expected, instead of a newonCreate
from a new activity instance.