-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FC] Debounce clicks on buttons and clickable surfaces #6836
Merged
carlosmuvi-stripe
merged 8 commits into
master
from
carlosmuvi/BANKCON-7096/fc-debounce-clicks-on-buttons-and-clickable-surfac
Jun 9, 2023
Merged
[FC] Debounce clicks on buttons and clickable surfaces #6836
carlosmuvi-stripe
merged 8 commits into
master
from
carlosmuvi/BANKCON-7096/fc-debounce-clicks-on-buttons-and-clickable-surfac
Jun 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosmuvi-stripe
force-pushed
the
carlosmuvi/BANKCON-7096/fc-debounce-clicks-on-buttons-and-clickable-surfac
branch
from
June 8, 2023 21:21
3247737
to
d0b32b3
Compare
jameswoo-stripe
approved these changes
Jun 9, 2023
internal interface MultipleEventsCutter { | ||
fun processEvent(event: () -> Unit) | ||
|
||
companion object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very interesting syntax!
* A wrapper around [clickable] that prevents multiple clicks from being registered within a | ||
* short time frame. | ||
*/ | ||
internal interface MultipleEventsCutter { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we call this MultipleEventsDebouncer
? I haven't heard of the term Cutter before.
carlosmuvi-stripe
deleted the
carlosmuvi/BANKCON-7096/fc-debounce-clicks-on-buttons-and-clickable-surfac
branch
June 9, 2023 05:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
https://jira.corp.stripe.com/browse/BANKCON-7096
Testing
maestro test -e APP_ID=com.stripe.android.financialconnections.example maestro/financial-connections/