Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FC] Crash after authenticating when R8 full-mode is enabled #6813

Merged
merged 3 commits into from
Jun 1, 2023
Merged

[FC] Crash after authenticating when R8 full-mode is enabled #6813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff32046
[skip ci] Start PR
carlosmuvi-stripe Jun 1, 2023
cad3466
Adds proguard rules to keep MavericksState data classes
carlosmuvi-stripe Jun 1, 2023
a187372
Revert release gradle changes.
carlosmuvi-stripe Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion financial-connections-example/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
STRIPE_ANDROID_NAMESPACE=com.stripe.android.financialconnections.example
STRIPE_ANDROID_NAMESPACE=com.stripe.android.financialconnections.example
22 changes: 22 additions & 0 deletions financial-connections/consumer-rules.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,25 @@
-keep,allowobfuscation class ** implements com.airbnb.mvrx.MavericksViewModelFactory

-dontwarn com.google.crypto.tink.subtle.XChaCha20Poly1305


# MavericksViewModel loads the Companion class via reflection and thus we need to make sure we keep
# the name of the Companion object.
-keepclassmembers class ** extends com.airbnb.mvrx.MavericksViewModel {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we upstream this? Ideally we wouldn't need to add these ourselves.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll open an issue on Mavericks!

** Companion;
}

# Members of the Kotlin data classes used as the state in Mavericks are read via Kotlin reflection which cause trouble
# with Proguard if they are not kept.
# During reflection cache warming also the types are accessed via reflection. Need to keep them too.
-keepclassmembers,includedescriptorclasses,allowobfuscation class ** implements com.airbnb.mvrx.MavericksState {
*;
}

# The MavericksState object and the names classes that implement the MavericksState interface need to be
# kept as they are accessed via reflection.
-keepnames class com.airbnb.mvrx.MavericksState
-keepnames class * implements com.airbnb.mvrx.MavericksState

# MavericksViewModelFactory is referenced via reflection using the Companion class name.
-keepnames class * implements com.airbnb.mvrx.MavericksViewModelFactory