[stripe-ui-core] Fix phone number length #6771
Conversation
|
@stripe/stripe-identity-observers |
stripe-ui-core/src/main/java/com/stripe/android/uicore/elements/PhoneNumberFormatter.kt
Outdated
Show resolved
Hide resolved
| @@ -163,3 +168,6 @@ fun PhoneNumberElementUI( | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| @RestrictTo(RestrictTo.Scope.LIBRARY_GROUP) | |||
| const val PHONE_NUMBER_FIELD_TAG = "phone_number" | |||
There was a problem hiding this comment.
Is this used anywhere?
| @@ -39,6 +40,9 @@ import kotlinx.coroutines.job | |||
| import kotlinx.coroutines.launch | |||
| import com.stripe.android.core.R as CoreR | |||
|
|
|||
| @RestrictTo(RestrictTo.Scope.LIBRARY_GROUP) | |||
| const val PHONE_NUMBER_TEXT_FIELD_TAG = "PhoneNumberTextField" | |||
There was a problem hiding this comment.
Where is this being used? If it is not being used externally, can we keep this internal?
There was a problem hiding this comment.
It allows us to write test to programatically input a valid/invalid phone number and assert other states, such as this
| @@ -8,7 +8,7 @@ internal class PhoneNumberFormatterTest { | |||
|
|
|||
| @Test | |||
| fun `Phone number is correctly formatted for US locale`() { | |||
| val formatter = PhoneNumberFormatter.forCountry("US") | |||
| val formatter = PhoneNumberFormatter.forCountry("US") // "(###) ###-####" | |||
There was a problem hiding this comment.
Do we test every phone number that we support? If not, can we add tests for them? Do you think it is valuable to add tests for each country?
There was a problem hiding this comment.
hmm what we changed is just limiting the length of converted phone number, which is covered by the test, not sure adding a single test for each region adds too much value here, instead I added another test for a customized pattern
done |
Summary
Correctly calculate the phone number based on the pattern for known regions.
Motivation
Testing
Screenshots
Changelog
[Fixed] Fixed the length of phone number field.