-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add us_bank_account LPM filter #6687
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameswoo-stripe
force-pushed
the
jameswoo/lpm-us-bank-account-filter
branch
from
May 5, 2023 21:12
d399d8f
to
26b9f08
Compare
jameswoo-stripe
requested review from
tillh-stripe and
jaynewstrom-stripe
and removed request for
carlosmuvi-stripe
May 5, 2023 21:13
jameswoo-stripe
force-pushed
the
jameswoo/lpm-us-bank-account-filter
branch
from
May 5, 2023 21:18
26b9f08
to
cf475d3
Compare
Diffuse output:
APK
DEX
|
payments-ui-core/src/test/java/com/stripe/android/ui/core/forms/resources/LpmRepositoryTest.kt
Outdated
Show resolved
Hide resolved
jameswoo-stripe
force-pushed
the
jameswoo/lpm-us-bank-account-filter
branch
from
May 22, 2023 23:20
cf475d3
to
d801806
Compare
@@ -3157,7 +3157,7 @@ public final class com/stripe/android/model/PaymentIntent : com/stripe/android/m | |||
public fun getNextActionType ()Lcom/stripe/android/model/StripeIntent$NextActionType; | |||
public fun getPaymentMethod ()Lcom/stripe/android/model/PaymentMethod; | |||
public fun getPaymentMethodId ()Ljava/lang/String; | |||
public final fun getPaymentMethodOptions ()Ljava/util/Map; | |||
public fun getPaymentMethodOptions ()Ljava/util/Map; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can keep this final.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PaymentIntent is already final, so this method cannot be overriden.
payments-ui-core/src/test/java/com/stripe/android/ui/core/forms/resources/LpmRepositoryTest.kt
Outdated
Show resolved
Hide resolved
jameswoo-stripe
force-pushed
the
jameswoo/lpm-us-bank-account-filter
branch
from
May 23, 2023 06:14
867e31a
to
6d4123f
Compare
jameswoo-stripe
force-pushed
the
jameswoo/lpm-us-bank-account-filter
branch
from
May 23, 2023 06:16
6d4123f
to
a806309
Compare
jaynewstrom-stripe
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
us_bank_account
payment methodus_bank_account
, specifically for its requested verification method. If the desired verification method isinstant
orautomatic
, as described in the docs, then we can display the payment method, hide it otherwise.Can verify this with your own server.
Motivation
Hide the payment method when verification method is microdeposits as this would cause the user to not be able to complete payment.
Testing
Changelog
automatic
orinstant
, otherwise, hide the payment method.