Improve A11y of the stripe widget #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Strange, it looks like the failing tests do some network requests. |
mshafrir-stripe
requested changes
Dec 18, 2018
stripe/src/main/java/com/stripe/android/view/ExpiryDateEditText.java
Outdated
Show resolved
Hide resolved
stripe/src/main/java/com/stripe/android/view/CardNumberEditText.java
Outdated
Show resolved
Hide resolved
stripe/src/main/java/com/stripe/android/view/CardInputWidget.java
Outdated
Show resolved
Hide resolved
|
I ended up merging some of your changes in a separate patch (e.g. |
|
Done, although you are of course missing translations for these new strings. |
mshafrir-stripe
requested changes
Dec 27, 2018
stripe/src/main/java/com/stripe/android/view/ExpiryDateEditText.java
Outdated
Show resolved
Hide resolved
stripe/src/main/java/com/stripe/android/view/CardNumberEditText.java
Outdated
Show resolved
Hide resolved
stripe/src/main/java/com/stripe/android/view/CardInputWidget.java
Outdated
Show resolved
Hide resolved
Can you add the translations to the other strings files so that this PR passes lint? |
|
@mshafrir-stripe ok, done |
mshafrir-stripe
approved these changes
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on improving the accessibility of an app that uses the stripe widget and one issue that our accessibility auditors raised is that the stripe widget does not communicate its content well for non a11y users.
For example the credit card number will spout
1234 1234 1234 1234when you tap on it, which is not that useful.So I have modified how accessibility info is populated for this widget, this way :
I had to add a description for the CVC number editText, I have only added it in 2 languages since I am not fluent in all of them 😓
In addition, the 2 first edit text had
doneas their IME action. it meant that it was extremely hard to get to the next text field as an a11y user. Switching tonextfixes it.I had to fix a couple of lint warnings in order to be able to compile the lib, I have included them in this PR, I can remove them or move them to another PR if necessary.