Fix an issue where the primary button got extra wide on configuration changes. #6326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| android:text="@string/stripe_paymentsheet_pay_button_label" | ||
| android:visibility="gone" /> | ||
| android:layout_height="wrap_content"> | ||
| <!-- Needs to be wrapped in a FrameLayout to prevent layout issues after configuration changes. --> |
There was a problem hiding this comment.
My guess is it's a compose bug. But I didn't look to far into it since the mitigation was low cost.
I've run into this before, which is why I suspected this and fixed it here. The layout inflator isn't taking into account the root view (from this XML file) layout params into account when inflating the view. An easy way around that is to not have any layout params in the root view, but keep them in the nested view, which is what I did here.
tillh-stripe
reviewed
Mar 6, 2023
Co-authored-by: Till Hellmund <[email protected]>
tillh-stripe
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When causing a configuration change (I did it by changing from light theme to dark theme), the primary button would lose it's margin. This change wraps the primary button in a
FrameLayoutso the layout params of the PrimaryButton aren't lost.Motivation
It was a bug!
Testing
Screenshots