Add primaryButtonLabel property to Configuration
#5729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillh-stripe
force-pushed
the
tillh/custom-cta-label
branch
from
7d8cc9e to
7f33fd7
Compare
tillh-stripe
changed the title
customPrimaryButtonLabel property to ConfigurationprimaryButtonLabel property to Configuration
tillh-stripe
force-pushed
the
tillh/custom-cta-label
branch
from
dfc6e92 to
2336691
Compare
tillh-stripe
requested review from
brnunes-stripe,
jameswoo-stripe,
ccen-stripe and
awush-stripe
as code owners
jameswoo-stripe
previously approved these changes
Oct 28, 2022
jameswoo-stripe
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds the property
primaryButtonLabeltoPaymentSheet.Configuration, allowing consumers to pass in a custom label.Motivation
RUN_MOBILESDK-1642
Testing
Screen recording
custom_cta.mp4
Changelog
Added support for a custom primary button label via
PaymentSheet.Configuration.primaryButtonLabel.