-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with limited postal code input #5715
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillh-stripe
force-pushed
the
tillh/postal-code-fix
branch
from
October 17, 2022 15:50
e21d20b
to
a67be4b
Compare
Diffuse output:
APK
|
tillh-stripe
force-pushed
the
tillh/postal-code-fix
branch
from
October 17, 2022 16:24
022ba73
to
3593e19
Compare
tillh-stripe
commented
Oct 17, 2022
FieldError(R.string.address_zip_postal_invalid) | ||
} | ||
else -> null | ||
} | ||
} | ||
|
||
override fun isFull(): Boolean = input.length >= format.minimumLength | ||
override fun isFull(): Boolean = input.length >= format.maximumLength |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this doesn’t impact the resolution of the issue, it makes more sense to me than the previous implementation: A field is full when it reaches the maximum length, not when it exceeds the minimum length.
tillh-stripe
requested review from
brnunes-stripe,
jameswoo-stripe,
ccen-stripe and
awush-stripe
as code owners
October 17, 2022 16:45
jameswoo-stripe
approved these changes
Oct 17, 2022
brnunes-stripe
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes an issue where non-US and non-Canadian postal codes were limited to a single character.
Motivation
Resolves: #5714
Testing
Screenshots
Changelog
[FIXED] Postal codes for countries other than US and Canada are no longer limited to a single character.