Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds account_numbers permission and parses unknown enum values to UNKNOWN. #5583

Merged
merged 5 commits into from
Sep 20, 2022
Merged

Adds account_numbers permission and parses unknown enum values to UNKNOWN. #5583

merged 5 commits into from
Sep 20, 2022

Conversation

carlosmuvi-stripe
Copy link
Collaborator

@carlosmuvi-stripe carlosmuvi-stripe commented Sep 20, 2022 •
edited
Loading

Summary

  • Adds EnumIgnoreUnknownSerializer. coerceImputValues does not ignore unknown enum values for enum lists.
  • Adds missing account_numbers permission, the missing enum value that surfaced this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2022 •
edited
Loading

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │          compressed          │          uncompressed          
          ├──────────┬──────────┬────────┼───────────┬───────────┬────────
 APK      │ old      │ new      │ diff   │ old       │ new       │ diff   
──────────┼──────────┼──────────┼────────┼───────────┼───────────┼────────
      dex │ 15.8 MiB │ 15.8 MiB │ +152 B │  53.4 MiB │  53.4 MiB │ -440 B 
     arsc │  1.8 MiB │  1.8 MiB │    0 B │   1.8 MiB │   1.8 MiB │    0 B 
 manifest │  4.1 KiB │  4.1 KiB │    0 B │  18.9 KiB │  18.9 KiB │    0 B 
      res │    1 MiB │    1 MiB │    0 B │   1.8 MiB │   1.8 MiB │    0 B 
   native │  2.5 MiB │  2.5 MiB │    0 B │   5.9 MiB │   5.9 MiB │    0 B 
    asset │    3 MiB │    3 MiB │  -61 B │     3 MiB │     3 MiB │  -61 B 
    other │ 81.8 KiB │ 81.8 KiB │    0 B │ 155.7 KiB │ 155.7 KiB │    0 B 
──────────┼──────────┼──────────┼────────┼───────────┼───────────┼────────
    total │ 24.2 MiB │ 24.2 MiB │  +91 B │    66 MiB │    66 MiB │ -501 B 

         │          raw           │             unique              
         ├────────┬────────┬──────┼────────┬────────┬───────────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff          
─────────┼────────┼────────┼──────┼────────┼────────┼───────────────
   files │      4 │      4 │    0 │        │        │               
 strings │ 256006 │ 256023 │  +17 │ 219024 │ 219030 │  +6 (+23 -17) 
   types │  45045 │  45050 │   +5 │  41438 │  41439 │  +1 (+6 -5)   
 classes │  38621 │  38622 │   +1 │  38621 │  38622 │  +1 (+6 -5)   
 methods │ 224982 │ 224957 │  -25 │ 217244 │ 217211 │ -33 (+17 -50) 
  fields │ 164375 │ 164371 │   -4 │ 163421 │ 163416 │  -5 (+10 -15) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  334 │  334 │  0   
 entries │ 6242 │ 6242 │  0
APK 
    compressed    │   uncompressed   │                                
─────────┬────────┼─────────┬────────┤                                
 size    │ diff   │ size    │ diff   │ path                           
─────────┼────────┼─────────┼────────┼────────────────────────────────
 2.4 MiB │ +152 B │ 7.4 MiB │ -440 B │ ∆ classes3.dex                 
 9.7 KiB │  -57 B │ 9.5 KiB │  -57 B │ ∆ assets/dexopt/baseline.prof  
   662 B │   -4 B │   530 B │   -4 B │ ∆ assets/dexopt/baseline.profm 
─────────┼────────┼─────────┼────────┼────────────────────────────────
 2.4 MiB │  +91 B │ 7.4 MiB │ -501 B │ (total)
DEX 
STRINGS:

   old    │ new    │ diff         
  ────────┼────────┼──────────────
   219024 │ 219030 │ +6 (+23 -17) 
  + �
  ���
  ���
  ���
  ����À��2�����0�0�B���¢����¨��
  + �
  ���
  ���
  
  ���
  ��	���� 
  2�����00�:�
  �B���������0�¢����R�����0�¢��
  ������j���j���j��	¨�
  + �
  ���
  ���
  
  ���
  ��
  ���� �2�����00�:��B���������0�¢����R�����0�¢��
  ������j���j���j��	j��
  ¨�
  + �
  ���
  ���
  
  ���
  ������� 2�����00�:�
  B���������0�¢����R�����0�¢��
  ������j���j���j��	j��
  j���¨��
  + �
  ���
  ���
  
  ���
  ������ 
  2�����00�:�
  �B���������0�¢����R�����0�¢��
  ������j���j���j��	j��
  j���j��¨��
  + �
  ���
  ���
  
  ���
  ��
  ���� �2�����00�:���B���������0�¢����R�����0�¢��
  ������j���j���j��	j��
  j���j��j��
  ¨��
  + B
  ���
  
  ���
  ���
  
  ���
  ���
  ���
  ���
  ��_
  ���
  ���
  ���
  ���
  ���
  
  ���
  ����'�*����*�����H�0�2�����H�0�B������
  ������80�������8¢����J�����82�����0�H�¢����J�����0�2�����0�2�����8H�¢����R�����8X��¢��
  ���R��	��0
  X��¢��
  �����R��
  ������8����0�0�X��¢��
  R���������0�����80�X��¢��
  R�����0�*�����80�8BX��¢��������¨��
  + (Ljava/lang/Enum;)Ljava/lang/String;
  + ([Ljava/lang/Enum;Ljava/lang/Enum;)V
  + ([TT;TT;)V
  + ACCOUNT_NUMBERS
  + EnumIgnoreUnknownSerializer.kt
  + Lcom/stripe/android/core/model/serializers/EnumIgnoreUnknownSerializer;
  + Lcom/stripe/android/core/model/serializers/EnumIgnoreUnknownSerializer<
  + Lcom/stripe/android/financialconnections/model/FinancialConnectionsAccount_Category_Serializer;
  + Lcom/stripe/android/financialconnections/model/FinancialConnectionsAccount_Permissions_Serializer;
  + Lcom/stripe/android/financialconnections/model/FinancialConnectionsAccount_Status_Serializer;
  + Lcom/stripe/android/financialconnections/model/FinancialConnectionsAccount_Subcategory_Serializer;
  + Lcom/stripe/android/financialconnections/model/FinancialConnectionsAccount_SupportedPaymentMethodTypes_Serializer;
  + SMAP
  EnumIgnoreUnknownSerializer.kt
  Kotlin
  *S Kotlin
  *F
  + 1 EnumIgnoreUnknownSerializer.kt
  com/stripe/android/core/model/serializers/EnumIgnoreUnknownSerializer
  + 2 _Arrays.kt
  kotlin/collections/ArraysKt___ArraysKt
  *L
  1#1,44:1
  8945#2,2:45
  9215#2,4:47
  8811#2,2:51
  9071#2,4:53
  *S KotlinDebug
  *F
  + 1 EnumIgnoreUnknownSerializer.kt
  com/stripe/android/core/model/serializers/EnumIgnoreUnknownSerializer
  *L
  27#1:45,2
  27#1:47,4
  28#1:51,2
  28#1:53,4
  *E
  
  + Serializer
  + account_numbers
  + revLookup
  
  - �
  ���
  ���
  
  ���
  ������� 
  2�����00�:�
  B���������0�¢����R�����0�¢��
  ������j���j���j��	j��
  j���¨��
  - �
  ���
  ���
  
  ���
  ��
  ���� �2�����00�:���B���������0�¢����R�����0�¢��
  ������j���j���j��	j��
  j���j��j��
  ¨��
  - Lcom/stripe/android/financialconnections/model/FinancialConnectionsAccount_Category__serializer;
  - Lcom/stripe/android/financialconnections/model/FinancialConnectionsAccount_Permissions__serializer;
  - Lcom/stripe/android/financialconnections/model/FinancialConnectionsAccount_Status__serializer;
  - Lcom/stripe/android/financialconnections/model/FinancialConnectionsAccount_Subcategory__serializer;
  - Lcom/stripe/android/financialconnections/model/FinancialConnectionsAccount_SupportedPaymentMethodTypes__serializer;
  - com.stripe.android.financialconnections.model.FinancialConnectionsAccount.Category
  - com.stripe.android.financialconnections.model.FinancialConnectionsAccount.Permissions
  - com.stripe.android.financialconnections.model.FinancialConnectionsAccount.Status
  - com.stripe.android.financialconnections.model.FinancialConnectionsAccount.Subcategory
  - com.stripe.android.financialconnections.model.FinancialConnectionsAccount.SupportedPaymentMethodTypes
  - com/stripe/android/financialconnections/model/FinancialConnectionsAccount.Category._serializer
  - com/stripe/android/financialconnections/model/FinancialConnectionsAccount.Permissions._serializer
  - com/stripe/android/financialconnections/model/FinancialConnectionsAccount.Status._serializer
  - com/stripe/android/financialconnections/model/FinancialConnectionsAccount.Subcategory._serializer
  - com/stripe/android/financialconnections/model/FinancialConnectionsAccount.SupportedPaymentMethodTypes._serializer
  

TYPES:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   41438 │ 41439 │ +1 (+6 -5) 
  + Lcom/stripe/android/core/model/serializers/EnumIgnoreUnknownSerializer;
  + Lcom/stripe/android/financial
...✂

@carlosmuvi-stripe carlosmuvi-stripe changed the title Adds account number permission. Adds account_numbers permission and parses unknown enum values to UNKNOWN. Sep 20, 2022
@carlosmuvi-stripe carlosmuvi-stripe requested review from a team and tillh-stripe and removed request for a team September 20, 2022 22:10
@carlosmuvi-stripe carlosmuvi-stripe marked this pull request as ready for review September 20, 2022 22:18
@carlosmuvi-stripe carlosmuvi-stripe merged commit 5701790 into master Sep 20, 2022
@carlosmuvi-stripe carlosmuvi-stripe deleted the b/adds-account-numbers-permission branch September 20, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccen-stripe ccen-stripe ccen-stripe approved these changes

@tillh-stripe tillh-stripe Awaiting requested review from tillh-stripe tillh-stripe was automatically assigned from stripe/stripe-android-sdk-reviewers

Assignees

@carlosmuvi-stripe carlosmuvi-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlosmuvi-stripe @ccen-stripe