Fix expiry date field issue in CardInputWidget
#5547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillh-stripe
changed the title
CardInputWidget
|
Diffuse output: APKDEX |
mshafrir-stripe
previously approved these changes
Sep 14, 2022
| } | ||
| } | ||
|
|
||
| addTextChangedListener(textWatcher) |
There was a problem hiding this comment.
Thinking out loud: listenForDeleteEmpty() is only called once in the constructor, so this is safe. If this constraint were to change, we wouldn't want to add multiple text watchers.
There was a problem hiding this comment.
Right, I added a check to make sure we only ever add this once. Just in case this is ever moved anywhere else.
tillh-stripe
force-pushed
the
tillh/5539-expiry-date-field-formatting
branch
2 times, most recently
from
c2642f6 to
34db268
Compare
tillh-stripe
requested review from
brnunes-stripe,
ccen-stripe,
jameswoo-stripe and
awush-stripe
as code owners
ccen-stripe
previously requested changes
Sep 22, 2022
| @@ -86,6 +86,12 @@ open class StripeEditText @JvmOverloads constructor( | |||
|
|
|||
| private var errorMessageListener: ErrorMessageListener? = null | |||
|
|
|||
| private val isLastKeyDeleteTextWatcher = object : StripeTextWatcher() { | |||
There was a problem hiding this comment.
should we also add a test in StripeEditTextTest?
tillh-stripe
force-pushed
the
tillh/5539-expiry-date-field-formatting
branch
from
2576cf9 to
10abb95
Compare
|
As mentioned in #5539, I've manually tested the version supplied and it fixes the problem for me (which I could previously reliably replicate) |
jameswoo-stripe
previously approved these changes
Sep 27, 2022
tillh-stripe
force-pushed
the
tillh/5539-expiry-date-field-formatting
branch
from
887b73e to
f6da382
Compare
brnunes-stripe
previously approved these changes
Sep 27, 2022
tillh-stripe
force-pushed
the
tillh/5539-expiry-date-field-formatting
branch
from
f6da382 to
b0b0bc6
Compare
jameswoo-stripe
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes an issue in
CardInputWidgetthat occurred on some devices, such as those from Samsung.A quick explanation: On the affected devices, the
StripeEditText’sOnKeyListenerwasn’t called for all key presses, but only for presses of the backspace. With that, the class’sisLastKeyDeletewas alwaystrueafter a backspace press, resulting in theExpiryDateEditText’s text not being updated.We’re adding a
TextWatcherin addition to theOnKeyListenerto make sure that theisLastKeyDeleteproperty is always in the correct state.Also, we’re removing the
!isLastKeyDeletecondition inExpiryDateEditText’safterTextChanged. This condition prevented a behavior we actually want: If the current text is12 / 2and the user presses backspace, we want to end up with12instead of12 /. This behavior was explicitly called out in a comment, but must have been broken some time ago.Motivation
Resolves: #5539
Testing
Screenshots
Changelog
[Fixed] Expiry dates in
CardInputWidget,CardMultilineWidget, andCardFormVieware no longer formatted incorrectly on certain devices.