Add postal validation #5456
Add postal validation #5456
Conversation
jameswoo-stripe
requested review from
brnunes-stripe,
michelleb-stripe and
tillh-stripe
as code owners
jameswoo-stripe
force-pushed
the
jameswoo/paymentsheet-postalcode
branch
from
06251fc to
aaf6d54
Compare
jameswoo-stripe
requested review from
ccen-stripe and
awush-stripe
as code owners
jameswoo-stripe
force-pushed
the
jameswoo/paymentsheet-postalcode
branch
from
aaf6d54 to
3b66ec4
Compare
| SimpleTextFieldController( | ||
| val textFieldConfig = when (it) { | ||
| FieldType.PostalCode -> { | ||
| addressField.schema?.nameType |
There was a problem hiding this comment.
Can this be removed?
| object CA : CountryPostalFormat( | ||
| minimumLength = 6, | ||
| maximumLength = 6, | ||
| regexPattern = Regex("([a-zA-Z]\\d)+") |
There was a problem hiding this comment.
Should we allow spaces for Canadian postal codes? Currently, it’s not possible to enter them.
There was a problem hiding this comment.
And another 🇨🇦 question: Should we auto-capitalize the postal code? I find a1b 2c3 looks odd, and A1B 2C3 looks much nicer.
There was a problem hiding this comment.
Added spacing regex, won't fix the auto-capitalization
Added through visual transformation
| override fun filter(userTyped: String): String = | ||
| if ( | ||
| setOf(KeyboardType.Number, KeyboardType.NumberPassword).contains(keyboard) | ||
| ) { | ||
| userTyped.filter { it.isDigit() } | ||
| } else { | ||
| userTyped | ||
| }.replace(Regex("\\s*"), "") |
There was a problem hiding this comment.
On iOS, it looks like we restrict the input length to the country’s maximum length. Can we do the same here?
jameswoo-stripe
force-pushed
the
jameswoo/paymentsheet-postalcode
branch
from
3b66ec4 to
db98039
Compare
jameswoo-stripe
force-pushed
the
jameswoo/paymentsheet-postalcode
branch
from
db98039 to
507accf
Compare
| maximumLength = 9, | ||
| regexPattern = Regex("\\d+") | ||
| ) | ||
| object Other : CountryPostalFormat( |
There was a problem hiding this comment.
Is this copied from stripe.js or somewhere else? Just making sure we're not being too strict on the requirements. Better to not validate than to validate it wrong and end up not accepting a valid value, which frustrates the user.
| val maximumLength: Int, | ||
| val regexPattern: Regex | ||
| ) { | ||
| object CA : CountryPostalFormat( |
There was a problem hiding this comment.
Since you're accepting the space, should it take up to 7 characters now?
| maximumLength = 6, | ||
| regexPattern = Regex("[a-zA-Z]\\d[a-zA-Z][\\s-]?\\d[a-zA-Z]\\d") | ||
| ) | ||
| object US : CountryPostalFormat( |
There was a problem hiding this comment.
Usually a 9-digit zip code is formatted as 12345-6789.
This and the spaces for CA would be better handled by a VisualTransformation, like we have for the card number and others. For these two it would be a pretty simple one, I think it's worth taking a look.
jameswoo-stripe
assigned brnunes-stripe and tillh-stripe and unassigned jameswoo-stripe
Summary
Validate the postal code in payment sheet
Motivation
Testing
Screenshots
Changelog