BANKCON-4898 Adds stripeAccountId to FinancialConnectionsLauncher.Configuration. #5408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diffuse output: APKDEX |
carlosmuvi-stripe
requested review from
brnunes-stripe,
michelleb-stripe,
jameswoo-stripe,
ccen-stripe and
awush-stripe
as code owners
carlosmuvi-stripe
requested review from
charliecruzan-stripe
and removed request for
brnunes-stripe,
michelleb-stripe,
ccen-stripe and
awush-stripe
jameswoo-stripe
approved these changes
Aug 15, 2022
carlosmuvi-stripe
deleted the
b/BANKCON-4898_FinancialConnectionsLauncher_not_using_stripeAccountId
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Same that happened with
CollectBankAccountLauncher: Financial Connections was not accepting an optionalstripeAccountIdon its configuration object, required for Connected accounts. This PR adds it to the Configuration object and includes it as a header on internal API calls.The best way to test this flow is to use a merchant with a connected account and pass the accountId as a header when creating the PI / SI on the backend. Ensure the client app also passes the
stripeAccountIdparam matching the one used on the backend (you can defineSTRIPE_ACCOUNT_ID=acct_...in yourgradle.properties).Then, on the
exampleapp go toConnect US bank account, Before this PR, an ACHv2 payment would fail (Not a valid financialConnectionsSession). Now it should work.Testing
Changelog
Financial Connections
FinancialConnectionsSheet#Configurationnow accepts
stripeAccountIdfor Connect merchants.