BANKCON-4898 CollectBankAccountLauncher not using stripeAccountId #5399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diffuse output: APKDEX |
carlosmuvi-stripe
requested review from
brnunes-stripe,
michelleb-stripe,
skyler-stripe,
jameswoo-stripe,
ccen-stripe and
awush-stripe
as code owners
carlosmuvi-stripe
requested review from
charliecruzan-stripe
and removed request for
brnunes-stripe,
michelleb-stripe,
ccen-stripe,
awush-stripe and
skyler-stripe
| clientSecret.value, | ||
| CollectBankAccountConfiguration.USBankAccount( | ||
| publishableKey = lazyPaymentConfig.get().publishableKey, | ||
| stripeAccountId = lazyPaymentConfig.get().stripeAccountId, |
There was a problem hiding this comment.
@jameswoo-stripe Looks like PaymentSheet would be having this this issue as well, fixed that too.
There was a problem hiding this comment.
Yea, thanks for getting this fix in!
charliecruzan-stripe
previously approved these changes
Aug 11, 2022
carlosmuvi-stripe
dismissed stale reviews from charliecruzan-stripe and jameswoo-stripe
via
1b8acd4
|
@charliecruzan-stripe @jameswoo-stripe Updated - there's another API call to attach the PI / SI to the FinancialConnectionsSession, added the |
carlosmuvi-stripe
changed the title
carlosmuvi-stripe
assigned charliecruzan-stripe and jameswoo-stripe and unassigned carlosmuvi-stripe
charliecruzan-stripe
previously approved these changes
Aug 12, 2022
gradle.properties
Outdated
Comment on lines
18
to
19
| # delete | ||
| # PUBLISHABLE_KEY=pk_live_Uxk6GdfUJzeCePW1FdQmeOFM |
There was a problem hiding this comment.
This should be deleted?
There was a problem hiding this comment.
ooops, done!
jameswoo-stripe
approved these changes
Aug 12, 2022
carlosmuvi-stripe
deleted the
b/BANKCON-4898_CollectBankAccountForLauncher_not_using_stripeAccountId
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CollectBankAccountLauncherwas not acceptingstripeAccountId, required when making API calls on merchants using Connect.This PR updates the method signature to accept an optional
stripeAccountIdString.Motivation
https://jira.corp.stripe.com/browse/BANKCON-4898
Testing
Changelog