-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PaymentSheet] Fix issue opening the keyboard with small form #4961
Merged
michelleb-stripe
merged 2 commits into
master
from
michelleb/fix-single-lpm-single-field
May 6, 2022
Merged
[PaymentSheet] Fix issue opening the keyboard with small form #4961
michelleb-stripe
merged 2 commits into
master
from
michelleb/fix-single-lpm-single-field
May 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelleb-stripe
requested review from
brnunes-stripe,
skyler-stripe and
jameswoo-stripe
as code owners
May 5, 2022 19:00
Diffuse output:
APK
DEX
|
jameswoo-stripe
previously approved these changes
May 5, 2022
brnunes-stripe
previously approved these changes
May 6, 2022
michelleb-stripe
dismissed stale reviews from brnunes-stripe and jameswoo-stripe
via
May 6, 2022 16:32
3ceb1c5
brnunes-stripe
approved these changes
May 6, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When google pay is not available and a single LPM with a single input field is shown, when the keyboard is open it is immediately dismissed. Upon investigation this is because the bottom sheet size goes to 0 - clearing the focus of the field prior to bringing up the keyboard.
Motivation
#4570
Testing
Changelog