Fix crash when switching between LPMs. #4921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelleb-stripe
requested review from
brnunes-stripe,
skyler-stripe and
jameswoo-stripe
as code owners
michelleb-stripe
requested review from
ccen-stripe and
awush-stripe
as code owners
|
Diffuse output: APKDEX |
|
Is it possible to add a test for this? |
skyler-stripe
previously approved these changes
Apr 27, 2022
| @@ -101,11 +105,18 @@ internal abstract class BaseAddPaymentMethodFragment : Fragment() { | |||
| sheetViewModel.eventReporter.onShowNewPaymentOptionForm() | |||
| } | |||
|
|
|||
| override fun onStop() { | |||
| super.onStop() | |||
| composeFragmentFieldValues?.cancel() | |||
There was a problem hiding this comment.
This feels like we may not be scoping the job correctly. Is it possible to scope the lifecycle of the job to this fragment rather than manually canceling the job?
There was a problem hiding this comment.
@awush-stripe I moved the BaseSheetViewModel so it is accessible from the ComposeFormDataCollectionFragment. It was slightly akward as the VIewModel could be a PaymentSheetActivityViewModel or a PaymentOptionsActivityViewModel. It seems to work calling activityViewModels from onViewCreated, but would be curious to hear if there was a better way to handle this.
paymentsheet/src/main/java/com/stripe/android/paymentsheet/BaseAddPaymentMethodFragment.kt
Outdated
Show resolved
Hide resolved
michelleb-stripe
assigned awush-stripe, brnunes-stripe, skyler-stripe, jameswoo-stripe and carlosmuvi-stripe and unassigned michelleb-stripe
paymentsheet/src/main/java/com/stripe/android/paymentsheet/BaseAddPaymentMethodFragment.kt
Outdated
Show resolved
Hide resolved
jameswoo-stripe
previously approved these changes
May 2, 2022
jameswoo-stripe
approved these changes
May 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When switching between LPMs the form view model was reported collected fields for the new LPM even though all fields were not filled out. This resulted in the PaymentMethodCreateParameters to be wrongly created (it should not be created until all fields on the new LPM are complete), and causing the access of the last 4 of the card number to cause a crash.
Testing
Changelog