Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames connections to financial connections. #4887

Merged
merged 9 commits into from
Apr 19, 2022

Conversation

carlosmuvi-stripe
Copy link
Collaborator

@carlosmuvi-stripe carlosmuvi-stripe commented Apr 19, 2022

Summary

Renames all Connections occurrences to Financial Connections.

No code changes, just relocation and renaming. Some relocated files are treated as new files on git.

- Classes within the code: Connections -> FinancialConnections
- Android Maven published artifact: com.stripe:connections -> com.stripe.financial-connections
- Package structure and manifest: com.stripe.android.connections -> com.stripe.android.financialconnections
- Module: connections -> financial-connections

Testing

  • Manually verified an ACH payment end to end.

Changelog

Nothing here is available, so this rename shouldn't show up in the changelog.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 19, 2022

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │  13.2 MiB │  13.2 MiB │ -3.2 KiB │  44.2 MiB │  44.2 MiB │ +1.6 KiB 
     arsc │   1.6 MiB │   1.6 MiB │      0 B │   1.6 MiB │   1.6 MiB │      0 B 
 manifest │   2.9 KiB │   2.9 KiB │      0 B │  12.3 KiB │  12.3 KiB │      0 B 
      res │ 675.1 KiB │ 675.1 KiB │      0 B │   1.1 MiB │   1.1 MiB │      0 B 
    asset │  79.4 KiB │  79.4 KiB │     +2 B │ 108.9 KiB │ 108.9 KiB │     +2 B 
    other │    80 KiB │    80 KiB │      0 B │ 154.9 KiB │ 154.9 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  15.6 MiB │  15.6 MiB │ -3.2 KiB │  47.1 MiB │  47.1 MiB │ +1.6 KiB 

         │          raw           │            unique             
         ├────────┬────────┬──────┼────────┬────────┬─────────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff        
─────────┼────────┼────────┼──────┼────────┼────────┼─────────────
   files │      3 │      3 │    0 │        │        │             
 strings │ 213200 │ 213203 │   +3 │ 188023 │ 188023 │ 0 (+27 -27) 
   types │  36825 │  36833 │   +8 │  34236 │  34236 │ 0 (+18 -18) 
 classes │  31661 │  31661 │    0 │  31661 │  31661 │ 0 (+9 -9)   
 methods │ 189828 │ 189833 │   +5 │ 183905 │ 183905 │ 0 (+36 -36) 
  fields │ 130556 │ 130552 │   -4 │ 129716 │ 129716 │ 0 (+11 -11) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  292 │  292 │  0   
 entries │ 5593 │ 5593 │  0
APK
     compressed      │     uncompressed     │                               
──────────┬──────────┼──────────┬───────────┤                               
 size     │ diff     │ size     │ diff      │ path                          
──────────┼──────────┼──────────┼───────────┼───────────────────────────────
  3.5 MiB │ -9.1 KiB │ 10.2 MiB │ -20.9 KiB │ ∆ classes3.dex                
  3.2 MiB │ +6.1 KiB │  8.7 MiB │ +23.5 KiB │ ∆ classes2.dex                
  6.5 MiB │   -274 B │ 25.3 MiB │  -1,016 B │ ∆ classes.dex                 
  7.6 KiB │     +2 B │  7.4 KiB │      +2 B │ ∆ assets/dexopt/baseline.prof 
──────────┼──────────┼──────────┼───────────┼───────────────────────────────
 13.2 MiB │ -3.2 KiB │ 44.2 MiB │  +1.6 KiB │ (total)
DEX
STRINGS:

   old    │ new    │ diff        
  ────────┼────────┼─────────────
   188023 │ 188023 │ 0 (+27 -27) 
  + Lcom/stripe/android/financialconnections/FinancialConnectionsSheetResult_Canceled;
  + Lcom/stripe/android/financialconnections/FinancialConnectionsSheetResult_Completed;
  + Lcom/stripe/android/financialconnections/FinancialConnectionsSheetResult_Failed;
  + Lcom/stripe/android/financialconnections/FinancialConnectionsSheetResult;
  + Lcom/stripe/android/financialconnections/model/LinkAccountSession;
  + Lcom/stripe/android/payments/financialconnections/FinancialConnectionsPaymentsProxy_Companion;
  + Lcom/stripe/android/payments/financialconnections/FinancialConnectionsPaymentsProxy;
  + Lcom/stripe/android/payments/financialconnections/IsFinancialConnectionsAvailable;
  + financialConnectionsPaymentsProxy
  + onConnectionsResult(Lcom/stripe/android/financialconnections/FinancialConnectionsSheetResult;)V
  + (Lcom/stripe/android/financialconnections/FinancialConnectionsSheet;)V
  + FinancialConnectionsPaymentsProxy.kt
  + IsFinancialConnectionsAvailable.kt
  + Lcom/stripe/android/financialconnections/FinancialConnectionsSheet_Companion;
  + Lcom/stripe/android/financialconnections/FinancialConnectionsSheet_Configuration;
  + Lcom/stripe/android/financialconnections/FinancialConnectionsSheet;
  + Lcom/stripe/android/financialconnections/FinancialConnectionsSheetResultCallback;
  + Lcom/stripe/android/payments/financialconnections/DefaultFinancialConnectionsPaymentsProxy;
  + Lcom/stripe/android/payments/financialconnections/DefaultIsFinancialConnectionsAvailable;
  + Lcom/stripe/android/payments/financialconnections/FinancialConnectionsPaymentsProxy_Companion_create_1;
  + Lcom/stripe/android/payments/financialconnections/FinancialConnectionsPaymentsProxy_Companion_create_2;
  + Lcom/stripe/android/payments/financialconnections/FinancialConnectionsPaymentsProxy_sam_com_stripe_android_financialconnections_FinancialConnectionsSheetResultCallback_0;
  + Lcom/stripe/android/payments/financialconnections/UnsupportedFinancialConnectionsPaymentsProxy;
  + com.stripe.android.financialconnections.FinancialConnectionsSheet
  + financialConnectionsSheet
  + isFinancialConnectionsAvailable
  + onFinancialConnectionsSheetResult
  
  - (Lcom/stripe/android/connections/ConnectionsSheet;)V
  - ConnectionsPaymentsProxy.kt
  - IsConnectionsAvailable.kt
  - Lcom/stripe/android/connections/ConnectionsSheet_Companion;
  - Lcom/stripe/android/connections/ConnectionsSheet_Configuration;
  - Lcom/stripe/android/connections/ConnectionsSheet;
  - Lcom/stripe/android/connections/ConnectionsSheetResult_Canceled;
  - Lcom/stripe/android/connections/ConnectionsSheetResult_Completed;
  - Lcom/stripe/android/connections/ConnectionsSheetResult_Failed;
  - Lcom/stripe/android/connections/ConnectionsSheetResult;
  - Lcom/stripe/android/connections/ConnectionsSheetResultCallback;
  - Lcom/stripe/android/connections/model/LinkAccountSession;
  - Lcom/stripe/android/payments/connections/ConnectionsPaymentsProxy_Companion_create_1;
  - Lcom/stripe/android/payments/connections/ConnectionsPaymentsProxy_Companion_create_2;
  - Lcom/stripe/android/payments/connections/ConnectionsPaymentsProxy_Companion;
  - Lcom/stripe/android/payments/connections/ConnectionsPaymentsProxy_sam_com_stripe_android_connections_ConnectionsSheetResultCallback_0;
  - Lcom/stripe/android/payments/connections/ConnectionsPaymentsProxy;
  - Lcom/stripe/android/payments/connections/DefaultConnectionsPaymentsProxy;
  - Lcom/stripe/android/payments/connections/UnsupportedConnectionsPaymentsProxy;
  - Lcom/stripe/android/payments/connections/reflection/DefaultIsConnectionsAvailable;
  - Lcom/stripe/android/payments/connections/reflection/IsConnectionsAvailable;
  - com.stripe.android.connections.ConnectionsSheet
  - connectionsPaymentsProxy
  - connectionsSheet
  - isConnectionsAvailable
  - onConnectionsResult(Lcom/stripe/android/connections/ConnectionsSheetResult;)V
  - onConnectionsSheetResult
  

TYPES:

   old   │ new   │ diff        
  ───────┼───────┼─────────────
   34236 │ 34236 │ 0 (+18 -18) 
  + Lcom/stripe/android/financialconnections/FinancialConnectionsSheetResult_Canceled;
  + Lcom/stripe/android/financialconnections/FinancialConnectionsSheetResult_Completed;
  + Lcom/stripe/android/financialconnections/FinancialConnectionsSheetResult_Failed;
  + Lcom/stripe/android/financialconnections/FinancialConnectionsSheetResult;
  + Lcom/stripe/android/financialconnectio
...✂

Copy link
Contributor

@jameswoo-stripe jameswoo-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looked through and lgtm

@carlosmuvi-stripe carlosmuvi-stripe merged commit c20ae87 into master Apr 19, 2022
@carlosmuvi-stripe carlosmuvi-stripe deleted the f/rename-financial-connections branch April 19, 2022 23:56
@carlosmuvi-stripe carlosmuvi-stripe added the financial-connections Relates to the Financial Connections SDK label Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
financial-connections Relates to the Financial Connections SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants