Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] POC - Replaces roboto ttf by downloadable font. #4825

Closed
wants to merge 1 commit into from

Conversation

carlosmuvi-stripe
Copy link
Collaborator

Summary

@carlosmuvi-stripe carlosmuvi-stripe changed the title Replaces roboto ttf by downloadable font. [WIP] POC - Replaces roboto ttf by downloadable font. Apr 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │            compressed             │            uncompressed            
          ├───────────┬───────────┬───────────┼───────────┬───────────┬────────────
 APK      │ old       │ new       │ diff      │ old       │ new       │ diff       
──────────┼───────────┼───────────┼───────────┼───────────┼───────────┼────────────
      dex │  12.6 MiB │  12.6 MiB │    +134 B │  42.5 MiB │  42.5 MiB │     +984 B 
     arsc │   1.6 MiB │   1.6 MiB │  +3.4 KiB │   1.6 MiB │   1.6 MiB │   +3.4 KiB 
 manifest │   2.8 KiB │   2.8 KiB │       0 B │  12.1 KiB │  12.1 KiB │        0 B 
      res │ 760.6 KiB │ 675.1 KiB │ -85.5 KiB │   1.2 MiB │   1.1 MiB │ -163.8 KiB 
    asset │  78.4 KiB │  77.9 KiB │    -512 B │ 107.8 KiB │ 107.3 KiB │     -512 B 
    other │  79.6 KiB │  79.6 KiB │      -4 B │ 154.6 KiB │ 154.6 KiB │        0 B 
──────────┼───────────┼───────────┼───────────┼───────────┼───────────┼────────────
    total │  15.1 MiB │    15 MiB │ -82.4 KiB │  45.5 MiB │  45.4 MiB │ -159.9 KiB 

         │          raw           │             unique             
         ├────────┬────────┬──────┼────────┬────────┬──────────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff         
─────────┼────────┼────────┼──────┼────────┼────────┼──────────────
   files │      3 │      3 │    0 │        │        │              
 strings │ 204767 │ 204778 │  +11 │ 181367 │ 181374 │  +7 (+7 -0)  
   types │  35102 │  35105 │   +3 │  32726 │  32729 │  +3 (+3 -0)  
 classes │  30215 │  30218 │   +3 │  30215 │  30218 │  +3 (+3 -0)  
 methods │ 176400 │ 176403 │   +3 │ 170967 │ 170970 │  +3 (+3 -0)  
  fields │ 118551 │ 118563 │  +12 │ 117804 │ 117816 │ +12 (+12 -0) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  293 │  294 │ +1 (+1 -0) 
 entries │ 5575 │ 5579 │ +4 (+4 -0)
APK
      compressed      │     uncompressed      │                                                                
──────────┬───────────┼──────────┬────────────┤                                                                
 size     │ diff      │ size     │ diff       │ path                                                           
──────────┼───────────┼──────────┼────────────┼────────────────────────────────────────────────────────────────
          │ -85.8 KiB │          │ -164.3 KiB │ - res/1v.ttf                                                   
  1.6 MiB │  +3.4 KiB │  1.6 MiB │   +3.4 KiB │ ∆ resources.arsc                                               
    6 KiB │    -512 B │  5.8 KiB │     -512 B │ ∆ assets/dexopt/baseline.prof                                  
    368 B │    +368 B │    504 B │     +504 B │ + res/dj.xml                                                   
    3 MiB │     +96 B │  8.5 MiB │     +380 B │ ∆ classes3.dex                                                 
  3.1 MiB │     +21 B │  8.7 MiB │     +604 B │ ∆ classes2.dex                                                 
  6.5 MiB │     +17 B │ 25.3 MiB │        0 B │ ∆ classes.dex                                                  
    980 B │     +11 B │  2.6 KiB │        0 B │ ∆ res/R5.xml                                                   
    1 KiB │     +10 B │  2.5 KiB │        0 B │ ∆ res/ro.xml                                                   
    977 B │      -6 B │  2.5 KiB │        0 B │ ∆ res/3T.xml                                                   
  1.3 KiB │      -6 B │  1.2 KiB │        0 B │ ∆ res/6t.9.png                                                 
    374 B │      +6 B │    272 B │        0 B │ ∆ res/8T.png                                                   
    747 B │      -6 B │    651 B │        0 B │ ∆ res/BG.png                                                   
    344 B │      -6 B │    244 B │        0 B │ ∆ res/Dt.9.png                                                 
    315 B │      -6 B │    215 B │        0 B │ ∆ res/Pq.9.png                                                 
    535 B │      +6 B │    429 B │        0 B │ ∆ res/Pv.9.png                                                 
    585 B │      -6 B │    489 B │        0 B │ ∆ res/Wh.png                                                   
    335 B │      -6 B │    235 B │        0 B │ ∆ res/X3.9.png                                                 
  1.6 KiB │      -6 B │  1.5 KiB │        0 B │ ∆ res/aO.9.png                                                 
    321 B │      -6 B │    221 B │        0 B │ ∆ res/dH.9.png                                                 
  1.2 KiB │      -6 B │  1.1 KiB │        0 B │ ∆ res/gV.9.png                                                 
    445 B │      -6 B │    345 B │        0 B │ ∆ res/ld.9.png                                                 
    571 B │      +6 B │    465 B │        0 B │ ∆ res/uW.9.png                                                 
    513 B │      +5 B │    900 B │        0 B │ ∆ res/4F1.xml                                                  
    999 B │      +5 B │  2.8 KiB │        0 B │ ∆ res/AE.xml                                                   
    184 B │      -4 B │      6 B │        0 B │ ∆ META-INF/androidx.activity_activity-compose.version          
  1.1 KiB │      -4 B │    984 B │        0 B │ ∆ res/9t.png                                                   
  2.8 KiB │      +4 B │  2.7 KiB │        0 B │ ∆ res/K7.9.png                                                 
    207 B │      +4 B │    107 B │        0 B │ ∆ res/LD.png                                                   
    269 B │      -4 B │    171 B │        0 B │ ∆ res/L_.png                                                   
    313 B │      +4 B │    209 B │        0 B │ ∆ res/Lq.9.png                                                 
    286 B │      -4 B │    186 B │        0 B │ ∆ res/bu.9.png                                                 
    388 B │      -4 B │    286 B │        0 B │ ∆ res/ca.9.png                                                 
    314 B │      -4 B │    212 B │        0 B │ ∆ res/jK.9.png                                                 
    280 B │      -4 B │    178 B │        0 B │ ∆ res/kK.9.png                                                 
    499 B │      +4 B │    395 B │        0 B │ ∆ res/pF.9.png                                                 
    317 B │      -4 
...✂
DEX
STRINGS:

   old    │ new    │ diff       
  ────────┼────────┼────────────
   181367 │ 181374 │ +7 (+7 -0) 
  + Lcom/stripe/android/paymentsheet/R_array;
  + Lcom/stripe/android/paymentsheet/example/R_array;
  + com_google_android_gms_fonts_certs
  + com_google_android_gms_fonts_certs_dev
  + com_google_android_gms_fonts_certs_prod
  + preloaded_fonts
  + Lcom/stripe/android/ui/core/R_array;
  

TYPES:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   32726 │ 32729 │ +3 (+3 -0) 
  + Lcom/stripe/android/paymentsheet/R_array;
  + Lcom/stripe/android/paymentsheet/example/R_array;
  + Lcom/stripe/android/ui/core/R_array;
  

METHODS:

   old    │ new    │ diff       
  ────────┼────────┼────────────
   170967 │ 170970 │ +3 (+3 -0) 
  + com.stripe.android.paymentsheet.R_array <init>()
  + com.stripe.android.paymentsheet.example.R_array <init>()
  + com.stripe.android.ui.core.R_array <init>()
  

FIELDS:

   old    │ new    │ diff         
  ────────┼────────┼──────────────
   117804 │ 117816 │ +12 (+12 -0) 
  + com.stripe.android.paymentsheet.R_array com_google_android_gms_fonts_certs: int
  + com.stripe.android.paymentsheet.R_array com_google_android_gms_fonts_certs_dev: int
  + com.stripe.android.paymentsheet.R_array com_google_android_gms_fonts_certs_prod: int
  + com.stripe.android.paymentsheet.R_array preloaded_fonts: int
  + com.stripe.android.paymentsheet.example.R_array com_google_android_gms_fonts_certs: int
  + com.stripe.android.paymentsheet.example.R_array com_google_android_gms_fonts_certs_dev: int
  + com.stripe.android.paymentsheet.example.R_array com_google_android_gms_fonts_certs_prod: int
  + com.stripe.android.paymentsheet.example.R_array preloaded_fonts: int
  + com.stripe.android.ui.core.R_array com_google_android_gms_fonts_certs: int
  + com.stripe.android.ui.core.R_array com_google_android_gms_fonts_certs_dev: int
  + com.stripe.android.ui.core.R_array com_google_android_gms_fonts_certs_prod: int
  + com.stripe.android.ui.core.R_array preloaded_fonts: int
ARSC
CONFIGS:

   old │ new │ diff       
  ─────┼─────┼────────────
   293 │ 294 │ +1 (+1 -0) 
  + array
  

ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   5575 │ 5579 │ +4 (+4 -0) 
  + array/com_google_android_gms_fonts_certs
  + array/com_google_android_gms_fonts_certs_dev
  + array/com_google_android_gms_fonts_certs_prod
  + array/preloaded_fonts

@skyler-stripe
Copy link
Contributor

Closing in favor of: #4861

Turns out Compose isn't friendly with downloaded fonts. Thanks for the suggestion though.

@carlosmuvi-stripe carlosmuvi-stripe added the financial-connections Relates to the Financial Connections SDK label Jul 22, 2022
@tillh-stripe tillh-stripe deleted the poc/downloadable-fonts branch October 20, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
financial-connections Relates to the Financial Connections SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants