[stripe-core] Remove network related internal files #4803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccen-stripe
force-pushed
the
removeInternalFiles
branch
from
81d62b9 to
5222bd6
Compare
ccen-stripe
requested review from
awush-stripe,
brnunes-stripe,
michelleb-stripe,
skyler-stripe and
jameswoo-stripe
as code owners
awush-stripe
approved these changes
Mar 31, 2022
|
Diffuse output: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the following internal files
InternalStripeFileInternalStripeFileParamsInternalStripeFilePurposeMove their correspondents from payments to stripe-core
com.stripe.android.AppInfo->com.stripe.android.core.AppInfocom.stripe.android.model.StripeFile->com.stripe.android.core.model.StripeFilecom.stripe.android.model.StripeFileParams->com.stripe.android.core.model.StripeFileParamscom.stripe.android.model.StripeFilePurpose->com.stripe.android.core.model.StripeFilePurposeMotivation
Code resuse
Testing
Screenshots
Changelog
[Changed]: The following classes' packages are changed:
com.stripe.android.AppInfo->com.stripe.android.core.AppInfocom.stripe.android.model.StripeFile->com.stripe.android.core.model.StripeFilecom.stripe.android.model.StripeFileParams->com.stripe.android.core.model.StripeFileParamscom.stripe.android.model.StripeFilePurpose->com.stripe.android.core.model.StripeFilePurpose