Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update 3ds2 to v6.1.5 #4747

Merged
merged 1 commit into from
Mar 22, 2022
Merged

update 3ds2 to v6.1.5 #4747

merged 1 commit into from
Mar 22, 2022

Conversation

skyler-stripe
Copy link
Contributor

Summary

Update 3ds2 SDK to latest version.

Motivation

fixes:
#4723

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2022

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │           compressed           │           uncompressed           
          ├──────────┬──────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old      │ new      │ diff     │ old       │ new       │ diff     
──────────┼──────────┼──────────┼──────────┼───────────┼───────────┼──────────
      dex │ 12.5 MiB │ 12.5 MiB │ +1.8 KiB │  42.3 MiB │  42.3 MiB │ +2.7 KiB 
     arsc │  1.6 MiB │  1.6 MiB │      0 B │   1.6 MiB │   1.6 MiB │      0 B 
 manifest │  2.8 KiB │  2.8 KiB │      0 B │  11.8 KiB │  11.8 KiB │      0 B 
      res │  699 KiB │  699 KiB │      0 B │   1.1 MiB │   1.1 MiB │      0 B 
    asset │ 78.9 KiB │ 78.9 KiB │     +3 B │ 108.4 KiB │ 108.4 KiB │     +3 B 
    other │ 79.6 KiB │ 79.6 KiB │     -4 B │ 154.6 KiB │ 154.6 KiB │      0 B 
──────────┼──────────┼──────────┼──────────┼───────────┼───────────┼──────────
    total │   15 MiB │   15 MiB │ +1.8 KiB │  45.2 MiB │  45.2 MiB │ +2.7 KiB 

         │          raw           │             unique             
         ├────────┬────────┬──────┼────────┬────────┬──────────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff         
─────────┼────────┼────────┼──────┼────────┼────────┼──────────────
   files │      3 │      3 │    0 │        │        │              
 strings │ 203796 │ 203818 │  +22 │ 180669 │ 180691 │ +22 (+26 -4) 
   types │  34807 │  34808 │   +1 │  32496 │  32497 │  +1 (+1 -0)  
 classes │  30004 │  30005 │   +1 │  30004 │  30005 │  +1 (+1 -0)  
 methods │ 175309 │ 175327 │  +18 │ 169966 │ 169983 │ +17 (+17 -0) 
  fields │ 117969 │ 117973 │   +4 │ 117230 │ 117234 │  +4 (+4 -0)  

 ARSC    │ old  │ new  │ diff      
─────────┼──────┼──────┼───────────
 configs │  298 │  298 │ 0 (+1 -1) 
 entries │ 5568 │ 5568 │ 0
APK
     compressed     │    uncompressed    │                                                       
─────────┬──────────┼─────────┬──────────┤                                                       
 size    │ diff     │ size    │ diff     │ path                                                  
─────────┼──────────┼─────────┼──────────┼───────────────────────────────────────────────────────
 3.1 MiB │ +1.8 KiB │ 8.6 MiB │ +2.7 KiB │ ∆ classes2.dex                                        
   184 B │     -4 B │     6 B │      0 B │ ∆ META-INF/androidx.activity_activity-compose.version 
   7 KiB │     +3 B │ 6.9 KiB │     +3 B │ ∆ assets/dexopt/baseline.prof                         
─────────┼──────────┼─────────┼──────────┼───────────────────────────────────────────────────────
 3.1 MiB │ +1.8 KiB │ 8.6 MiB │ +2.7 KiB │ (total)
DEX
STRINGS:

   old    │ new    │ diff         
  ────────┼────────┼──────────────
   180669 │ 180691 │ +22 (+26 -4) 
  + 3DS_LOA_SDK_STIN_020100_00142
  + 6.1.5
  + ; Failover JWK source retrieval failed with: 
  + Android3ds2Sdk 6.1.5
  + Illegal JWK thumbprint prefix
  + Illegal JWK thumbprint: Missing value
  + Illegal JWK thumbprint: The hash algorithm must not be empty
  + Illegal JWK thumbprint: Unexpected number of components
  + Lcom/nimbusds/jose/jwk/ThumbprintURI;
  + Non-public key in jwk header parameter
  + The JWK must be public
  + The hash algorithm must not be null or empty
  + The thumbprint must not be null or empty
  + ThumbprintURI.java
  + [email protected]+22
  + computeThumbprintURI
  + failover
  + failoverJWKSource
  + getAlgorithmString
  + getFailoverJWKSource
  + getThumbprint
  + hashAlg
  + parsePublicJWK
  + sha-256
  + thumbprint
  + urn:ietf:params:oauth:jwk-thumbprint:
  
  - 3DS_LOA_SDK_UTSB_020100_00007
  - 6.1.4
  - Android3ds2Sdk 6.1.4
  - [email protected]+21
  

TYPES:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   32496 │ 32497 │ +1 (+1 -0) 
  + Lcom/nimbusds/jose/jwk/ThumbprintURI;
  

METHODS:

   old    │ new    │ diff         
  ────────┼────────┼──────────────
   169966 │ 169983 │ +17 (+17 -0) 
  + com.nimbusds.jose.CommonSEHeader parsePublicJWK(Map) → JWK
  + com.nimbusds.jose.KeySourceException getMessage() → String
  + com.nimbusds.jose.jwk.JWK computeThumbprintURI() → ThumbprintURI
  + com.nimbusds.jose.jwk.ThumbprintURI <init>(String, Base64URL)
  + com.nimbusds.jose.jwk.ThumbprintURI compute(JWK) → ThumbprintURI
  + com.nimbusds.jose.jwk.ThumbprintURI equals(Object) → boolean
  + com.nimbusds.jose.jwk.ThumbprintURI getAlgorithmString() → String
  + com.nimbusds.jose.jwk.ThumbprintURI getThumbprint() → Base64URL
  + com.nimbusds.jose.jwk.ThumbprintURI hashCode() → int
  + com.nimbusds.jose.jwk.ThumbprintURI parse(String) → ThumbprintURI
  + com.nimbusds.jose.jwk.ThumbprintURI parse(URI) → ThumbprintURI
  + com.nimbusds.jose.jwk.ThumbprintURI toString() → String
  + com.nimbusds.jose.jwk.ThumbprintURI toURI() → URI
  + com.nimbusds.jose.jwk.source.RemoteJWKSet <init>(URL, JWKSource)
  + com.nimbusds.jose.jwk.source.RemoteJWKSet <init>(URL, JWKSource, ResourceRetriever, JWKSetCache)
  + com.nimbusds.jose.jwk.source.RemoteJWKSet failover(Exception, JWKSelector, SecurityContext) → List
  + com.nimbusds.jose.jwk.source.RemoteJWKSet getFailoverJWKSource() → JWKSource
  

FIELDS:

   old    │ new    │ diff       
  ────────┼────────┼────────────
   117230 │ 117234 │ +4 (+4 -0) 
  + com.nimbusds.jose.jwk.ThumbprintURI PREFIX: String
  + com.nimbusds.jose.jwk.ThumbprintURI hashAlg: String
  + com.nimbusds.jose.jwk.ThumbprintURI thumbprint: Base64URL
  + com.nimbusds.jose.jwk.source.RemoteJWKSet failoverJWKSource: JWKSource
ARSC
CONFIGS:

   old │ new │ diff      
  ─────┼─────┼───────────
   298 │ 298 │ 0 (+1 -1) 
  + string-in-rID
  
  - string-id-rID

@skyler-stripe skyler-stripe merged commit 3084951 into master Mar 22, 2022
@skyler-stripe skyler-stripe deleted the update3ds2 branch March 22, 2022 21:07
carlosmuvi-stripe pushed a commit that referenced this pull request Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants