Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global config from card scan #4689

Merged
merged 8 commits into from
Mar 11, 2022
Merged

Conversation

awush-stripe
Copy link
Collaborator

@awush-stripe awush-stripe commented Mar 11, 2022

Summary

Remove the global configuration from card scan and replace with an instance

Motivation

More predictable state throughout the SDK.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Changelog

CardScan

  • [ADDED] 4689 The CardImageVerificationSheet initializer can now take an additional Configuration object.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2022

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │         compressed         │         uncompressed         
          ├──────────┬──────────┬──────┼───────────┬───────────┬──────
 APK      │ old      │ new      │ diff │ old       │ new       │ diff 
──────────┼──────────┼──────────┼──────┼───────────┼───────────┼──────
      dex │ 12.5 MiB │ 12.5 MiB │  0 B │  42.2 MiB │  42.2 MiB │  0 B 
     arsc │  1.6 MiB │  1.6 MiB │  0 B │   1.6 MiB │   1.6 MiB │  0 B 
 manifest │  2.8 KiB │  2.8 KiB │  0 B │  11.8 KiB │  11.8 KiB │  0 B 
      res │  699 KiB │  699 KiB │  0 B │   1.1 MiB │   1.1 MiB │  0 B 
    asset │ 78.7 KiB │ 78.7 KiB │  0 B │ 108.2 KiB │ 108.2 KiB │  0 B 
    other │ 79.6 KiB │ 79.6 KiB │  0 B │ 154.6 KiB │ 154.6 KiB │  0 B 
──────────┼──────────┼──────────┼──────┼───────────┼───────────┼──────
    total │ 14.9 MiB │ 14.9 MiB │  0 B │  45.1 MiB │  45.1 MiB │  0 B 

         │          raw           │           unique            
         ├────────┬────────┬──────┼────────┬────────┬───────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff      
─────────┼────────┼────────┼──────┼────────┼────────┼───────────
   files │      3 │      3 │    0 │        │        │           
 strings │ 203422 │ 203422 │    0 │ 180385 │ 180385 │ 0 (+0 -0) 
   types │  34710 │  34710 │    0 │  32427 │  32427 │ 0 (+0 -0) 
 classes │  29944 │  29944 │    0 │  29944 │  29944 │ 0 (+0 -0) 
 methods │ 174934 │ 174934 │    0 │ 169628 │ 169628 │ 0 (+0 -0) 
  fields │ 117738 │ 117738 │    0 │ 117003 │ 117003 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  298 │  298 │  0   
 entries │ 5561 │ 5561 │  0

@awush-stripe
Copy link
Collaborator Author

ptal? @ccen-stripe @jaimepark-stripe

ccen-stripe
ccen-stripe previously approved these changes Mar 11, 2022
Copy link
Contributor

@ccen-stripe ccen-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick heads up since this update stripecardscan.api it seems it would break older versions, payments usually add some entry in MIGRATING.md, not sure if it's also needed here

@ccen-stripe
Copy link
Contributor

quick heads up since this update stripecardscan.api it seems it would break older versions, payments usually add some entry in MIGRATING.md, not sure if it's also needed here

Also should we add an entry in the changelog for this?

@awush-stripe awush-stripe merged commit e1dfe81 into master Mar 11, 2022
@awush-stripe awush-stripe deleted the awush/clean_up_config branch March 11, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants