-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove global config from card scan #4689
Conversation
Diffuse output:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick heads up since this update stripecardscan.api
it seems it would break older versions, payments usually add some entry in MIGRATING.md, not sure if it's also needed here
Also should we add an entry in the changelog for this? |
Summary
Remove the global configuration from card scan and replace with an instance
Motivation
More predictable state throughout the SDK.
Testing
Changelog
CardScan
CardImageVerificationSheet
initializer can now take an additionalConfiguration
object.