-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing app info to some Stripe API requests #4557
Conversation
Diffuse output:
APK
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could you add some more detail in the testing?
@skyler-stripe done. |
r-codeowners? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a better way is to provide the AppInfo
through Dagger, like all other parameters in this constructor. Or, to make things easier, keep this constructor as is and make the default Stripe.appInfo
instead of null in line 95
@brnunes-stripe Can you confirm that |
Maybe a better question is: are there any requests where we should not be providing app info? |
I think those cases are also bugs, if the user sets the |
f9d7a47
to
db513f1
Compare
@brnunes-stripe @skyler-stripe Updated primary constructor and CHANGELOG. |
Thanks! |
6eae2d0
6eae2d0
to
a0e46d2
Compare
Rebased master to resolve CHANGELOG merge conflict. |
Summary
Add missing app info to the headers of some Stripe API requests.
Motivation
RUN_MOBILESDK-728
Testing
Steps taken:
Stripe.appInfo
is being set in the appuser-agent
andx-stripe-client-user-agent
request headers include the AppInfo part