revert static height on cmw text boxes #4408
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This reverts my change here: #4266
Motivation
We've been getting some user issues: #4389
Making the text boxes
wrap_content
for CardMultilineWidget is okay now that we'll have a compose version of the card payment form for payment sheet. Then we won't need the height of CardMultilineWidget static for payment sheet. We'll be able to set text box heights independently of other UIs and keep it uniform across all payment sheet PM forms. For now with this change, the text boxes will be slightly taller but CardMultilineWidget users will not see cutoff text. (until this pr #4358 then the issue will go away completely)This also fixes a spacing issue where the new card icons were sitting on the divider lines with no spacing.
Testing
Screenshots