Add klarna to sdk w/ example #4325
Conversation
skyler-stripe
requested review from
brnunes-stripe,
ccen-stripe and
michelleb-stripe
as code owners
| @Test | ||
| fun createPaymentMethod_withKlarna_shouldCreateObject() { | ||
| val missingAddressException = assertFailsWith<InvalidRequestException>( | ||
| "Address is required to create a klarna payment method" |
There was a problem hiding this comment.
where are these messages from? is it possible to build them programmatically?
There was a problem hiding this comment.
These messages come from the Stripe api's error messages, we parse the response. So there's not really any way to generate them programatically. I was following the after pay example here. I don't think there's a much cleaner way.
payments-core/src/test/java/com/stripe/android/PaymentMethodEndToEndTest.kt
Show resolved
Hide resolved
stripe-ci
assigned skyler-stripe and unassigned brnunes-stripe, michelleb-stripe, ccen-stripe and porter-stripe
| @@ -33,6 +34,10 @@ internal class StripeIntentViewModel( | |||
| customerId?.let { | |||
| mapOf("customer_id" to it) | |||
| }.orEmpty() | |||
| ).plus( | |||
| supportedPaymentMethods?.let { | |||
| mapOf("supported_payment_methods" to it) | |||
There was a problem hiding this comment.
I wonder should we exhaust this to customize all possible params provided by the toy server(not needed in this PR)
There was a problem hiding this comment.
True. It might be good to just have them all there in case we need them in the future. Unfortunately, it's not super well documented. That's why I only added this one for now.
Summary
Add Klarna as a payment method and make an example activity that confirms it.
Add optional param to our Base intent example to pass
SupportedPaymentMethodsso the example backend returns the requested payment methods with the payment intent.Motivation
Eventually we'll add support to this for payment sheet, so we should also have it in the SDK bindings just to be complete. Right now Klarna only requires an email and a country code. They're planning on removing that email requirement, so I will add the custom country selector in the future and for now it's hardcoded.
Testing
Screenshots